From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com,
richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org,
stefanha@redhat.com, pbonzini@redhat.com,
marcandre.lureau@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH v2 8/8] tests/tcg: build tests with -Werror
Date: Fri, 11 Dec 2020 08:55:50 +0100 [thread overview]
Message-ID: <ea96a9e5-a7e2-fc62-56bd-2ac04bd2fb9b@redhat.com> (raw)
In-Reply-To: <20201210190417.31673-9-alex.bennee@linaro.org>
On 10/12/2020 20.04, Alex Bennée wrote:
> Hopefully this will guard against sloppy code getting into our tests.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/tcg/Makefile.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
> index 2ae86776cd..24d75a5801 100644
> --- a/tests/tcg/Makefile.target
> +++ b/tests/tcg/Makefile.target
> @@ -94,7 +94,7 @@ ifdef CONFIG_USER_ONLY
> -include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.target
>
> # Add the common build options
> -CFLAGS+=-Wall -O0 -g -fno-strict-aliasing
> +CFLAGS+=-Wall -Werror -O0 -g -fno-strict-aliasing
> ifeq ($(BUILD_STATIC),y)
> LDFLAGS+=-static
> endif
I hope this works out as expected ... -Werror together with -O0 hopefully
does not trigger any false-positives since the compiler might not smart
enough in this case to determine e.g. whether certain variables are used or
not? Well, let's try and see.
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-12-11 7:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 19:04 [PATCH v2 0/8] testing/next (without-features, gitlab, python) Alex Bennée
2020-12-10 19:04 ` [PATCH v2 1/8] configure: include moxie-softmmu in deprecated_targets_list Alex Bennée
2020-12-11 6:18 ` Thomas Huth
2020-12-11 18:46 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 2/8] gitlab: include aarch64-softmmu and ppc64-softmmu cross-system-build Alex Bennée
2020-12-11 6:14 ` Thomas Huth
2020-12-11 18:49 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 3/8] configure: move gettext detection to meson.build Alex Bennée
2020-12-16 14:19 ` Alex Bennée
2020-12-16 14:30 ` Paolo Bonzini
2020-12-16 15:27 ` Alex Bennée
2020-12-16 15:35 ` Paolo Bonzini
2020-12-10 19:04 ` [PATCH v2 4/8] configure: add --without-default-features Alex Bennée
2020-12-11 7:53 ` Thomas Huth
2020-12-11 9:44 ` Alex Bennée
2020-12-10 19:04 ` [PATCH v2 5/8] python: add __repr__ to ConsoleSocket to aid debugging Alex Bennée
2020-12-10 19:04 ` [PATCH v2 6/8] gitlab: move --without-default-devices build from Travis Alex Bennée
2020-12-11 6:15 ` Thomas Huth
2020-12-11 18:55 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 7/8] gitlab: add --without-default-features build Alex Bennée
2020-12-11 6:16 ` Thomas Huth
2020-12-10 19:04 ` [PATCH v2 8/8] tests/tcg: build tests with -Werror Alex Bennée
2020-12-10 22:07 ` Philippe Mathieu-Daudé
2020-12-11 7:55 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea96a9e5-a7e2-fc62-56bd-2ac04bd2fb9b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).