From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, lizhengui@huawei.com
Cc: kwolf@redhat.com, xieyingtai@huawei.com, qemu-block@nongnu.org,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] virtio-iommu: fix incorrect print type
Date: Mon, 19 Oct 2020 15:24:00 -0500 [thread overview]
Message-ID: <ea9ac6fc-49f4-b3e9-eebb-26d2a1ec36ff@redhat.com> (raw)
In-Reply-To: <160311477740.18439.1188807654389468914@66eaa9a8a123>
On 10/19/20 8:39 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/1603114311-7392-1-git-send-email-lizhengui@huawei.com/
>
> c61a848 virtio-iommu: fix incorrect print type
>
> === OUTPUT BEGIN ===
> ERROR: Missing Signed-off-by: line(s)
>
> total: 1 errors, 0 warnings, 24 lines checked
>
> Commit c61a8487f435 (virtio-iommu: fix incorrect print type) has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
More than just a style problem, a missing S-o-b means we can't apply the
patch ;)
You may also want to group your related patches under a single thread
with a 0/N cover letter, rather than sending N threads of one patch each.
More patch submission hints at https://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-10-19 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 13:31 [PATCH] virtio-iommu: fix incorrect print type Zhengui li
2020-10-19 13:39 ` no-reply
2020-10-19 20:24 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-19 14:23 Zhengui li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea9ac6fc-49f4-b3e9-eebb-26d2a1ec36ff@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).