From: Hanna Reitz <hreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
jsnow@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
crosa@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v8 07/34] block/block-copy: introduce block_copy_set_copy_opts()
Date: Tue, 24 Aug 2021 15:32:48 +0200 [thread overview]
Message-ID: <eab0596b-ed0b-5570-2b08-8b6882ab5cc5@redhat.com> (raw)
In-Reply-To: <20210824083856.17408-8-vsementsov@virtuozzo.com>
On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
> We'll need a possibility to set compress and use_copy_range options
> after initialization of the state. So make corresponding part of
> block_copy_state_new() separate and public.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block-copy.h | 3 +++
> block/block-copy.c | 49 ++++++++++++++++++++++----------------
> 2 files changed, 32 insertions(+), 20 deletions(-)
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
next prev parent reply other threads:[~2021-08-24 13:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 8:38 [PATCH v8 00/34] block: publish backup-top filter Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 01/34] block: introduce bdrv_replace_child_bs() Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 02/34] block: introduce blk_replace_bs Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 03/34] qdev-properties: PropertyInfo: add realized_set_allowed field Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 04/34] qdev: allow setting drive property for realized device Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 05/34] block: rename backup-top to copy-before-write Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 06/34] block-copy: move detecting fleecing scheme to block-copy Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 07/34] block/block-copy: introduce block_copy_set_copy_opts() Vladimir Sementsov-Ogievskiy
2021-08-24 13:32 ` Hanna Reitz [this message]
2021-08-24 8:38 ` [PATCH v8 08/34] block/backup: set copy_range and compress after filter insertion Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 09/34] block/backup: move cluster size calculation to block-copy Vladimir Sementsov-Ogievskiy
2021-09-01 11:57 ` Hanna Reitz
2021-09-01 12:04 ` Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 10/34] block/copy-before-write: relax permission requirements when no parents Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failure path Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 12/34] block/copy-before-write: use file child instead of backing Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 13/34] block/copy-before-write: bdrv_cbw_append(): replace child at last Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 14/34] block/copy-before-write: introduce cbw_init() Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 15/34] block/copy-before-write: cbw_init(): rename variables Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 16/34] block/copy-before-write: cbw_init(): use file child after attaching Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 17/34] block/copy-before-write: bdrv_cbw_append(): drop unused compress arg Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 18/34] block/copy-before-write: cbw_init(): use options Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 19/34] block/copy-before-write: initialize block-copy bitmap Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 20/34] block/block-copy: make setting progress optional Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 21/34] block/copy-before-write: make public block driver Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 22/34] qapi: publish copy-before-write filter Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 23/34] python/qemu/machine.py: refactor _qemu_args() Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 24/34] python/qemu/machine: QEMUMachine: improve qmp() method Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 25/34] python:QEMUMachine: template typing for self returning methods Vladimir Sementsov-Ogievskiy
2021-08-24 13:56 ` Hanna Reitz
2021-08-24 8:38 ` [PATCH v8 26/34] iotests/222: fix pylint and mypy complains Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 27/34] iotests/222: constantly use single quotes for strings Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 28/34] iotests: move 222 to tests/image-fleecing Vladimir Sementsov-Ogievskiy
2021-09-01 12:37 ` Hanna Reitz
2021-09-01 12:47 ` Vladimir Sementsov-Ogievskiy
2021-09-01 12:54 ` Hanna Reitz
2021-09-01 13:00 ` Daniel P. Berrangé
2021-08-24 8:38 ` [PATCH v8 29/34] iotests.py: hmp_qemu_io: support qdev Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 30/34] iotests/image-fleecing: proper source device Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 31/34] iotests/image-fleecing: rename tgt_node Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 32/34] iotests/image-fleecing: prepare for adding new test-case Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 33/34] iotests/image-fleecing: add test-case for copy-before-write filter Vladimir Sementsov-Ogievskiy
2021-08-24 8:38 ` [PATCH v8 34/34] block/block-copy: block_copy_state_new(): drop extra arguments Vladimir Sementsov-Ogievskiy
2021-08-24 14:05 ` Hanna Reitz
2021-08-24 15:51 ` [PATCH v8 00/34] block: publish backup-top filter Hanna Reitz
2021-08-24 16:24 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab0596b-ed0b-5570-2b08-8b6882ab5cc5@redhat.com \
--to=hreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).