From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 07/46] target/loongarch: Implement xvneg
Date: Sun, 2 Jul 2023 08:00:33 +0200 [thread overview]
Message-ID: <eab94c6e-82fb-2ecc-4878-f5952c58d823@linaro.org> (raw)
In-Reply-To: <20230630075904.45940-8-gaosong@loongson.cn>
On 6/30/23 09:58, Song Gao wrote:
> +++ b/target/loongarch/insns.decode
> @@ -1311,11 +1311,6 @@ xvsub_w 0111 01000000 11010 ..... ..... ..... @vvv
> xvsub_d 0111 01000000 11011 ..... ..... ..... @vvv
> xvsub_q 0111 01010010 11011 ..... ..... ..... @vvv
>
> -xvreplgr2vr_b 0111 01101001 11110 00000 ..... ..... @vr
> -xvreplgr2vr_h 0111 01101001 11110 00001 ..... ..... @vr
> -xvreplgr2vr_w 0111 01101001 11110 00010 ..... ..... @vr
> -xvreplgr2vr_d 0111 01101001 11110 00011 ..... ..... @vr
> -
> xvaddi_bu 0111 01101000 10100 ..... ..... ..... @vv_ui5
> xvaddi_hu 0111 01101000 10101 ..... ..... ..... @vv_ui5
> xvaddi_wu 0111 01101000 10110 ..... ..... ..... @vv_ui5
> @@ -1325,6 +1320,11 @@ xvsubi_hu 0111 01101000 11001 ..... ..... ..... @vv_ui5
> xvsubi_wu 0111 01101000 11010 ..... ..... ..... @vv_ui5
> xvsubi_du 0111 01101000 11011 ..... ..... ..... @vv_ui5
>
> +xvneg_b 0111 01101001 11000 01100 ..... ..... @vv
> +xvneg_h 0111 01101001 11000 01101 ..... ..... @vv
> +xvneg_w 0111 01101001 11000 01110 ..... ..... @vv
> +xvneg_d 0111 01101001 11000 01111 ..... ..... @vv
> +
> xvreplgr2vr_b 0111 01101001 11110 00000 ..... ..... @vr
> xvreplgr2vr_h 0111 01101001 11110 00001 ..... ..... @vr
> xvreplgr2vr_w 0111 01101001 11110 00010 ..... ..... @vr
Ah hah, the rebase error gets fixed in the next patch.
This should be squashed.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-07-02 6:00 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 7:58 [PATCH v2 00/46] Add LoongArch LASX instructions Song Gao
2023-06-30 7:58 ` [PATCH v2 01/46] target/loongarch: Add LASX data support Song Gao
2023-07-02 5:51 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 02/46] target/loongarch: meson.build support build LASX Song Gao
2023-07-02 5:55 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 03/46] target/loongarch: Add CHECK_ASXE maccro for check LASX enable Song Gao
2023-06-30 7:58 ` [PATCH v2 04/46] target/loongarch: Implement xvadd/xvsub Song Gao
2023-07-02 5:55 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 05/46] target/loongarch: Implement xvreplgr2vr Song Gao
2023-07-02 5:56 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 06/46] target/loongarch: Implement xvaddi/xvsubi Song Gao
2023-07-02 5:59 ` Richard Henderson
2023-07-03 11:43 ` Song Gao
2023-06-30 7:58 ` [PATCH v2 07/46] target/loongarch: Implement xvneg Song Gao
2023-07-02 6:00 ` Richard Henderson [this message]
2023-06-30 7:58 ` [PATCH v2 08/46] target/loongarch: Implement xvsadd/xvssub Song Gao
2023-07-02 6:01 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 09/46] target/loongarch: Implement xvhaddw/xvhsubw Song Gao
2023-07-02 6:11 ` Richard Henderson
2023-07-03 11:43 ` Song Gao
2023-06-30 7:58 ` [PATCH v2 10/46] target/loongarch: Implement xvaddw/xvsubw Song Gao
2023-07-06 8:17 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 11/46] target/loongarch: Implement xavg/xvagr Song Gao
2023-07-06 8:18 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 12/46] target/loongarch: Implement xvabsd Song Gao
2023-07-06 8:18 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 13/46] target/loongarch: Implement xvadda Song Gao
2023-07-06 8:18 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 14/46] target/loongarch: Implement xvmax/xvmin Song Gao
2023-07-06 8:19 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 15/46] target/loongarch: Implement xvmul/xvmuh/xvmulw{ev/od} Song Gao
2023-06-30 7:58 ` [PATCH v2 16/46] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od} Song Gao
2023-07-07 11:07 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 17/46] target/loongarch; Implement xvdiv/xvmod Song Gao
2023-07-07 11:07 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 18/46] target/loongarch: Implement xvsat Song Gao
2023-07-07 11:10 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 19/46] target/loongarch: Implement xvexth Song Gao
2023-07-07 21:05 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 20/46] target/loongarch: Implement vext2xv Song Gao
2023-07-07 21:19 ` Richard Henderson
2023-07-08 7:24 ` Song Gao
2023-06-30 7:58 ` [PATCH v2 21/46] target/loongarch: Implement xvsigncov Song Gao
2023-07-08 6:58 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 22/46] target/loongarch: Implement xvmskltz/xvmskgez/xvmsknz Song Gao
2023-07-08 7:00 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 23/46] target/loognarch: Implement xvldi Song Gao
2023-07-08 7:02 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 24/46] target/loongarch: Implement LASX logic instructions Song Gao
2023-07-08 7:05 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 25/46] target/loongarch: Implement xvsll xvsrl xvsra xvrotr Song Gao
2023-07-08 7:05 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 26/46] target/loongarch: Implement xvsllwil xvextl Song Gao
2023-07-08 7:10 ` Richard Henderson
2023-06-30 7:58 ` [PATCH v2 27/46] target/loongarch: Implement xvsrlr xvsrar Song Gao
2023-06-30 7:58 ` [PATCH v2 28/46] target/loongarch: Implement xvsrln xvsran Song Gao
2023-06-30 7:58 ` [PATCH v2 29/46] target/loongarch: Implement xvsrlrn xvsrarn Song Gao
2023-06-30 7:58 ` [PATCH v2 30/46] target/loongarch: Implement xvssrln xvssran Song Gao
2023-06-30 7:58 ` [PATCH v2 31/46] target/loongarch: Implement xvssrlrn xvssrarn Song Gao
2023-06-30 7:58 ` [PATCH v2 32/46] target/loongarch: Implement xvclo xvclz Song Gao
2023-06-30 7:58 ` [PATCH v2 33/46] target/loongarch: Implement xvpcnt Song Gao
2023-06-30 7:58 ` [PATCH v2 34/46] target/loongarch: Implement xvbitclr xvbitset xvbitrev Song Gao
2023-06-30 7:58 ` [PATCH v2 35/46] target/loongarch: Implement xvfrstp Song Gao
2023-06-30 7:58 ` [PATCH v2 36/46] target/loongarch: Implement LASX fpu arith instructions Song Gao
2023-06-30 7:58 ` [PATCH v2 37/46] target/loongarch: Implement LASX fpu fcvt instructions Song Gao
2023-06-30 7:58 ` [PATCH v2 38/46] target/loongarch: Implement xvseq xvsle xvslt Song Gao
2023-06-30 7:58 ` [PATCH v2 39/46] target/loongarch: Implement xvfcmp Song Gao
2023-06-30 7:58 ` [PATCH v2 40/46] target/loongarch: Implement xvbitsel xvset Song Gao
2023-06-30 7:58 ` [PATCH v2 41/46] target/loongarch: Implement xvinsgr2vr xvpickve2gr Song Gao
2023-06-30 7:59 ` [PATCH v2 42/46] target/loongarch: Implement xvreplve xvinsve0 xvpickve xvb{sll/srl}v Song Gao
2023-06-30 7:59 ` [PATCH v2 43/46] target/loongarch: Implement xvpack xvpick xvilv{l/h} Song Gao
2023-06-30 7:59 ` [PATCH v2 44/46] target/loongarch: Implement xvshuf xvperm{i} xvshuf4i xvextrins Song Gao
2023-06-30 7:59 ` [PATCH v2 45/46] target/loongarch: Implement xvld xvst Song Gao
2023-06-30 7:59 ` [PATCH v2 46/46] target/loongarch: CPUCFG support LASX Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab94c6e-82fb-2ecc-4878-f5952c58d823@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).