From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F27BCC87FD2 for ; Thu, 31 Jul 2025 23:15:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhcTM-0001IS-Hn; Thu, 31 Jul 2025 19:14:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhcTK-0001FH-Bf for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:14:02 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhcTI-0006rr-Jl for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:14:02 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-76bc5e68d96so1086575b3a.3 for ; Thu, 31 Jul 2025 16:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754003639; x=1754608439; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cYPTbDjzEaWCey+wtOHfHEESLmZnJDv+3cu464DH5HI=; b=rsxNZNb7TSWHIyfPauqQhyLejWWLoS1IVtKl5MxEJl001AiFvRcxPzbzBtzCdGvAYw auvekX1SozHzLAKDEqneF5eKTBkXSHtmUonO4ByjmCHCa1PNhQ/aGntswCM2hCzrQRT6 6aQqLmeEmdMlgjboUCeO4X1+7Xl8VBfLDGGDM9xOXwQcfn+4y8/fPEHTZB7tECQwLAlr wwn2qCA0GtLECfvC261KIdCUvmD/otKBL/YeE08HWgQEhE3m0jueMYydN+fxGKfDe7HA HCSIHTZE/VHHPK50yvOADo6FCBnXPNqnqn2rNrN/QtSh2pcaitTdObHsJ/7gGk/tXoRC 55DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754003639; x=1754608439; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cYPTbDjzEaWCey+wtOHfHEESLmZnJDv+3cu464DH5HI=; b=nK1uTjYFZlm1cnOPXSh9DxvDYLqiOsVyTGFP5aU4u46WhGhny3Wrsq0WEvqbHdbbRW 8FOico8rmI6ZSkRgY5cX1UYzIPXaPvicSzHJXEWK4TyLUsxU6xs5sgGyIsUBWflyoRyn +Qx+3CYcTbJU5aZqDRessqpLed+F2IGFhdy1siv+zGz37539V784B6cd3lBrgIXlF1eQ m/xOC1Zg8tVzLEfrX/dOwUz8jls+GUrRBeKiPBdGRbUVMfCrDzhg1GbedJDbEerZwh+X JX2Qp+l3YKwQEGqxbOWpO0ijv6qViK+CJ3nPvLmrjro21uSqk+2NFbbDb8kMMlpikwXc p3Ug== X-Forwarded-Encrypted: i=1; AJvYcCVTZPukwIuEJ9K+2JlKJO7YYSnVGnYR195RToHO1bCsdnsLAvgoAtjBxdx/9ScxlHD1QqSmLGXwG8xR@nongnu.org X-Gm-Message-State: AOJu0YwdMa/tVeKA7nSXlT+SGchJ/j7Ulr/9RsSxJ7VJmdlx1Y/jqrWS g5H9C+FcW5IJjUXLEgL/VO6CEZd1y84OMxxzQ9jY8V2zsUyzMCmnG2KyNo+V/w1Lh7o= X-Gm-Gg: ASbGncujkMUdF35qjvmGYUrI73+ymLWs9B6hMzXzqu51aZU7zDrOCGB+Y6WNFe3C9wd lXNsd6hE3iXKo8V9A2eFFKoIkOh+I0aYw7qhbHCIVBDR7SHRgB0iLna7cXERwHbq5uv+kPuyp+L KUsW4EhbtaxqcEjrwrnk8V1y7aDOIf5yWqoMyCnJjCQ4X3AdEvBykSU+EePRBi58PNkFTR8uYGO DOpPoI/8PlO16DZaef97ijrmSVFyNVdwOfhkGRjo/7jnRgj/dDnwS4Xg2KIUV5vufhj6+y5ry5D sXs/ftBOP5axWtgMrF0sVGGAJr0KK1jwoAB9oYO3BwOEZIbAPVhRLCpXHmRzeYkbhZ5ShxsJYQQ lnhTk+yYg1oICnuM+kVjrx3VMGHWLw+c36ZTgNYQm X-Google-Smtp-Source: AGHT+IGsRN98CLR/SnSeHPdzeX2G5JVsxXGdzEJ1R4aa9XDZtz9oWR739MAwjppOBRU5wik98J5g1Q== X-Received: by 2002:a17:903:291:b0:23f:f68b:fa1d with SMTP id d9443c01a7336-24096b41b12mr122088465ad.39.1754003638658; Thu, 31 Jul 2025 16:13:58 -0700 (PDT) Received: from [192.168.4.112] ([180.233.125.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8976c40sm27705755ad.84.2025.07.31.16.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 16:13:58 -0700 (PDT) Message-ID: Date: Fri, 1 Aug 2025 09:13:48 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] semihosting/syscalls: compile once in system and per target for user mode To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Weiwei Li , philmd@linaro.org, Liu Zhiwei , Palmer Dabbelt , qemu-riscv@nongnu.org, Alistair Francis References: <20250730220621.1142496-1-pierrick.bouvier@linaro.org> <20250730220621.1142496-2-pierrick.bouvier@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250730220621.1142496-2-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 08:06, Pierrick Bouvier wrote: > We replace target_ulong mechanically by uint64_t. > We can't compile (easily) this code once for user, as it relies on > various target/function types, so leave it in specific_ss for user mode. > > Signed-off-by: Pierrick Bouvier > --- > include/semihosting/syscalls.h | 29 ++++++----- > semihosting/arm-compat-semi.c | 1 + > semihosting/syscalls.c | 89 +++++++++++++++++----------------- > semihosting/meson.build | 4 +- > 4 files changed, 62 insertions(+), 61 deletions(-) We can at least use vaddr for the pointers, like fname. I see syscalls.c already uses uint64_t in many of those places, but that can be a separate cleanup -- we don't need to add more. r~