From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jsnow@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] iotests: Use Python 3 style super()
Date: Wed, 28 Oct 2020 10:31:59 +0100 [thread overview]
Message-ID: <eaca727a-6eed-a65f-bd19-417f00a7d87e@redhat.com> (raw)
In-Reply-To: <20201027163806.290960-4-kwolf@redhat.com>
On 10/27/20 5:38 PM, Kevin Wolf wrote:
> pylint complains about the use of super with the current class and
> instance as arguments in VM.__init__():
>
> iotests.py:546:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments)
>
> No reason not to follow the advice and make it happy, so let's do this.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2020-10-28 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 16:38 [PATCH 0/3] iotests: Fix pylint/mypy warnings on F33 Kevin Wolf
2020-10-27 16:38 ` [PATCH 1/3] iotests.py: Fix type check errors in wait_migration() Kevin Wolf
2020-10-27 17:31 ` John Snow
2020-10-27 16:38 ` [PATCH 2/3] iotests: Disable unsubscriptable-object in pylint Kevin Wolf
2020-10-27 16:48 ` John Snow
2020-10-27 16:38 ` [PATCH 3/3] iotests: Use Python 3 style super() Kevin Wolf
2020-10-27 16:48 ` John Snow
2020-10-28 9:31 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaca727a-6eed-a65f-bd19-417f00a7d87e@redhat.com \
--to=philmd@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).