From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNMad-0003r9-5T for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNMaW-0001iy-Ts for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:42:06 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38591) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNMaW-0001X9-Gi for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:42:00 -0500 Received: by mail-wm1-f68.google.com with SMTP id f2-v6so18881173wme.3 for ; Thu, 15 Nov 2018 10:41:32 -0800 (PST) References: <20181115143124.19234-1-pbonzini@redhat.com> <20181115143124.19234-10-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 15 Nov 2018 19:41:28 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 09/10] vhost-user-test: small changes to init_hugepagefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: lvivier@redhat.com, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , jasowang@redhat.com, mst@redhat.com On 15/11/2018 15:55, Philippe Mathieu-Daudé wrote: >> >>       if (access(path, R_OK | W_OK | X_OK)) { >>           g_test_message("access on path (%s): %s\n", path, >> strerror(errno)); >> +        abort(); >>           return NULL; > > Can we remove the 'return NULL's now? > > Reviewed-by: Philippe Mathieu-Daudé I can remove them, but later on the aborts will become g_test_fail and the test will continue without hugepagefs. Paolo