qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-stable@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	marcandre.lureau@redhat.com, Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH] tests: Wait for migration completion on destination QEMU to avoid failures
Date: Fri, 18 Oct 2024 14:02:36 -0400	[thread overview]
Message-ID: <eadd4212-e662-4952-9e53-96e2c97f6c3b@linux.ibm.com> (raw)
In-Reply-To: <a3462080-f37d-45c9-a220-d3475b25997f@tls.msk.ru>



On 10/18/24 12:23 PM, Michael Tokarev wrote:
> 16.10.2024 18:21, Stefan Berger wrote:
>> Rather than waiting for the completion of migration on the source side,
>> wait for it on the destination QEMU side to avoid accessing the TPM TIS
>> memory mapped registers before QEMU could restore their state. This
>> error condition could be triggered on busy systems where the destination
>> QEMU did not have enough time to restore the TIS state while the test 
>> case
>> was already reading its registers. The test case was for example reading
>> the STS register and received an unexpected value (0xffffffff), which
>> lead to a segmentation fault later on due to trying to read 0xffff bytes
>> from the TIS into a buffer.
>>
>> Cc: qemu-stable@nongnu.org
>> Reported-by: Fabiano Rosas <farosas@suse.de>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> 
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
> 
> Queued for qemu-stable, though this one might better be applied through
> the test tree.

Thanks.  I actually already sent it as part of my PR today...

> 
> Thanks,
> 
> /mjt


      reply	other threads:[~2024-10-18 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 15:21 [PATCH] tests: Wait for migration completion on destination QEMU to avoid failures Stefan Berger
2024-10-16 15:27 ` Daniel P. Berrangé
2024-10-18 16:23 ` Michael Tokarev
2024-10-18 18:02   ` Stefan Berger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eadd4212-e662-4952-9e53-96e2c97f6c3b@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=farosas@suse.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).