Re: [PATCH] docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated

[Thomas Huth <thuth@redhat.com>]

On 18/10/2023 15.17, Michael S. Tsirkin wrote:
> On Fri, Oct 06, 2023 at 09:52:47AM +0200, Thomas Huth wrote:
>> As we've seen in the past, it's useful for deprecating old machine
>> types to finally be able to get of legacy code or do other clean-ups
>> (see e.g. commit ea985d235b868047 that was used to drop the PCI code in
>> the 128k bios binaries to free some precious space in those binaries).
>>
>> So let's continue deprecating the oldest pc machine types. QEMU 2.3
>> has been released 8 years ago, so that's plenty of time since such
>> machine types have been used by default, thus deprecating pc-i440fx-2.0
>> up to pc-i440fx-2.3 should be fine nowadays.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   docs/about/deprecated.rst | 8 ++++++++
>>   hw/i386/pc_piix.c         | 1 +
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index e43de9c183..c016bb9b20 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -277,6 +277,14 @@ deprecated; use the new name ``dtb-randomness`` instead. The new name
>>   better reflects the way this property affects all random data within
>>   the device tree blob, not just the ``kaslr-seed`` node.
>>   
>> +``pc-i440fx-2.0`` up to ``pc-i440fx-2.3`` (since 8.2)
>> +'''''''''''''''''''''''''''''''''''''''''''''''''''''
>> +
>> +These old machine types are quite neglected nowadays and thus might have
>> +various pitfalls with regards to live migration. Use a newer machine type
>> +instead.
>> +
>> +
>>   Backend options
>>   ---------------
> 
> Wait a sec. Which tree is this against?

It should be against master. The patch still applies cleanly for me... could 
you please double-check whether your master branch is up to date?

> I don't see this context ever since:
> 
> commit f59fb1889f480b0324a7ed0404a68ad5a0ad4f6c
> Author: Thomas Huth <thuth@redhat.com>
> Date:   Mon Jan 17 20:16:39 2022 +0100
> 
>      hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated

It's the context that has been left after Paolo moved the previous entries 
from deprecated.rst to removed-features.rst:

  https://gitlab.com/thuth/qemu/-/commit/ea985d235b868047cb4d8cb5657bc

> Also, do we intentionally keep 1.8 and 1.9 as not deprecated?

There never was a QEMU version 1.8 or 1.9, so there were never such machine 
types.

  Thomas