qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhukeqian via <qemu-devel@nongnu.org>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Wubin (H)" <wu.wubin@huawei.com>,
	"Chentao (Boby)" <boby.chen@huawei.com>,
	"Wanghaibin (D)" <wanghaibin.wang@huawei.com>,
	"Zhangbo (Oscar)" <oscar.zhangbo@huawei.com>,
	"limingwang (A)" <limingwang@huawei.com>,
	Wangyan <wangyan122@huawei.com>,
	lihuachao <lihuachao1@huawei.com>
Subject: 答复: [QUESTION] About virtio and eventloop
Date: Mon, 16 Jan 2023 08:54:12 +0000	[thread overview]
Message-ID: <eaf8c15d60264be8b30842c0f62efdca@huawei.com> (raw)
In-Reply-To: <63b89ae069d644b897ea97cc41b030ab@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

I found blk_drain() is invoked by virtio_blk_reset(), so only the second question remains :).

发件人: zhukeqian <>
发送时间: 2023年1月16日 16:18
收件人: 'Michael S. Tsirkin' <mst@redhat.com>; 'Stefan Hajnoczi' <stefanha@redhat.com>; 'Peter Maydell' <peter.maydell@linaro.org>
抄送: qemu-devel@nongnu.org; Wubin (H) <wu.wubin@huawei.com>; Chentao (Boby) <boby.chen@huawei.com>; Wanghaibin (D) <wanghaibin.wang@huawei.com>; Zhangbo (Oscar) <oscar.zhangbo@huawei.com>; limingwang (A) <limingwang@huawei.com>; Wangyan <wangyan122@huawei.com>; lihuachao <lihuachao1@huawei.com>
主题: [QUESTION] About virtio and eventloop

Hi all maintainers and community friends,

Recently I am reviewing and learning the virtio and eventloop implementation of latest QEMU,
and now I have a questions for help:

In general, the IO requests of virtio is popped in iothread/mainloop and may submitted to “async IO
Engine”  (io_uring/linux aio/threadpool). Once the IO operation is done, the “async IO engine” will send notification
to iothread/mainloop through evenfd or bottomhalf, and the completion action for the IO request (add used ring and
notify guest) is done in iothread/mainloop.

And let’s look at the “deactive” procedure of virtio-pci devices (when guest write 0 to  device status or system
triggered reset), the basic requirement is that device should stop handling IO requests and accessing virtqueue before
returning back to guest, as the guest may destroy virqueue  once deactivation is done.

QEMU invokes stop_ioeventfd() callback to perform above actions. It unregisters ioeventfd from eventloop and KVM,

  1.  but I can’t find code that ensuring IO operations in “async IO engine” are done.
  2.  And if IO operation is blocked, is vCPU thread will blocked when do deactivate?

It’s great that if anyone can help!

Thanks,
Keqian

[-- Attachment #2: Type: text/html, Size: 8210 bytes --]

  reply	other threads:[~2023-01-16  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16  8:18 [QUESTION] About virtio and eventloop zhukeqian via
2023-01-16  8:54 ` zhukeqian via [this message]
2023-01-16 16:16 ` Stefan Hajnoczi
2023-01-18 11:10   ` zhukeqian via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaf8c15d60264be8b30842c0f62efdca@huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=boby.chen@huawei.com \
    --cc=lihuachao1@huawei.com \
    --cc=limingwang@huawei.com \
    --cc=mst@redhat.com \
    --cc=oscar.zhangbo@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=wangyan122@huawei.com \
    --cc=wu.wubin@huawei.com \
    --cc=zhukeqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).