From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Michael S . Tsirkin" <mst@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
Igor Mammedov <imammedo@redhat.com>,
linux-kernel@vger.kernel.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: [PATCH 07/31] acpi/ghes: Change the type for source_id
Date: Fri, 6 Dec 2024 18:12:29 +0100 [thread overview]
Message-ID: <eb088a3b619b3be83c44e9c09dd01321a5451e51.1733504943.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1733504943.git.mchehab+huawei@kernel.org>
As described at: ACPI 6.5 spec at:
18.3.2. ACPI Error Source
In particular at GHES/GHESv2 table:
Table 18.10 Generic Hardware Error Source Structure
HEST source ID is actually a 16-bit value.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/ghes-stub.c | 2 +-
hw/acpi/ghes.c | 2 +-
include/hw/acpi/ghes.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/acpi/ghes-stub.c b/hw/acpi/ghes-stub.c
index c315de1802d6..2b64cbd2819a 100644
--- a/hw/acpi/ghes-stub.c
+++ b/hw/acpi/ghes-stub.c
@@ -11,7 +11,7 @@
#include "qemu/osdep.h"
#include "hw/acpi/ghes.h"
-int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address)
+int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address)
{
return -1;
}
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 5f67322bf0f2..edc74c38bf8a 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -383,7 +383,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s,
ags->present = true;
}
-int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address)
+int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address)
{
uint64_t error_block_addr, read_ack_register_addr, read_ack_register = 0;
uint64_t start_addr;
diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h
index 50e3a25ea384..9295e46be25e 100644
--- a/include/hw/acpi/ghes.h
+++ b/include/hw/acpi/ghes.h
@@ -73,7 +73,7 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors,
const char *oem_id, const char *oem_table_id);
void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s,
GArray *hardware_errors);
-int acpi_ghes_record_errors(uint8_t source_id, uint64_t error_physical_addr);
+int acpi_ghes_record_errors(uint16_t source_id, uint64_t error_physical_addr);
/**
* acpi_ghes_present: Report whether ACPI GHES table is present
--
2.47.1
next prev parent reply other threads:[~2024-12-06 17:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 17:12 [PATCH 00/31] Prepare GHES driver to support error injection Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 01/31] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 02/31] acpi/ghes: simplify acpi_ghes_record_errors() code Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 03/31] acpi/ghes: simplify the per-arch caller to build HEST table Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 04/31] acpi/ghes: better handle source_id and notification Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 05/31] acpi/ghes: Fix acpi_ghes_record_errors() argument Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 06/31] acpi/ghes: Remove a duplicated out of bounds check Mauro Carvalho Chehab
2024-12-06 17:12 ` Mauro Carvalho Chehab [this message]
2024-12-06 17:12 ` [PATCH 08/31] acpi/ghes: don't check if physical_address is not zero Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 09/31] acpi/ghes: make the GHES record generation more generic Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 10/31] acpi/ghes: better name GHES memory error function Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 11/31] acpi/ghes: don't crash QEMU if ghes GED is not found Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 12/31] acpi/ghes: rename etc/hardware_error file macros Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 13/31] acpi/ghes: better name the offset of the hardware error firmware Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 14/31] acpi/ghes: Prepare to support multiple sources on ghes Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 15/31] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 16/31] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 17/31] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 18/31] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 19/31] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 20/31] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 21/31] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 22/31] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 23/31] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 24/31] target/arm: add an experimental mpidr arm cpu property object Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 25/31] scripts/arm_processor_error.py: retrieve mpidr if not filled Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 26/31] acpi/ghes: move offset calculus to a separate function Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 27/31] DEBUG Mauro Carvalho Chehab
2024-12-07 3:38 ` Ani Sinha
2024-12-07 6:16 ` Markus Armbruster
2024-12-07 8:33 ` Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 28/31] acpi/ghes: Change ghes fill logic to work with only one source Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 29/31] HACK: use GPIO as source ID for virt-9.1 machines Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 30/31] docs: acpi_hest_ghes: fix documentation for CPER size Mauro Carvalho Chehab
2024-12-06 17:12 ` [PATCH 31/31] FIXME: acpi/ghes: properly set data record size Mauro Carvalho Chehab
2024-12-07 6:17 ` Markus Armbruster
2024-12-07 8:48 ` Mauro Carvalho Chehab
2024-12-07 6:11 ` [PATCH 00/31] Prepare GHES driver to support error injection Markus Armbruster
2024-12-07 6:15 ` Markus Armbruster
2024-12-07 8:39 ` Mauro Carvalho Chehab
2024-12-07 15:16 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb088a3b619b3be83c44e9c09dd01321a5451e51.1733504943.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).