From: Richard Henderson <richard.henderson@linaro.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: nd@arm.com, qemu-devel@nongnu.org
Subject: Re: another tst-arm-mte bug: qemu-system segfaults
Date: Fri, 5 Jun 2020 13:26:44 -0700 [thread overview]
Message-ID: <eb0a8d9e-e8fc-6738-1851-74320585b7ab@linaro.org> (raw)
In-Reply-To: <20200603171706.GH21536@arm.com>
On 6/3/20 10:17 AM, Szabolcs Nagy wrote:
> The 06/03/2020 09:21, Richard Henderson wrote:
>> On 6/3/20 6:50 AM, Szabolcs Nagy wrote:
>>> thanks my tests now get further but later i run into
>>> the previous assert failure:
>>>
>>> target/arm/mte_helper.c:97:allocation_tag_mem: assertion failed: (tag_size <= in_page)
>>>
>>> i might be able to reduce it to a small reproducer
>>> this time. i assume that will help.
>>
>> Dang, I had hoped that the one fix would cover both -- it's definitely in the
>> same area. Yes, a small reproducer will help, but I will also try again with
>> your larger reproducer.
>
> reproducer .c and static exe attached.
>
> the referenced __memcmp_aarch64 is again
> from the arm optimized-routines repo.
That assert is just wrong -- it's attempting to sanity check a virtual address
against a property associated with the physical address, and even doing that
incorrectly.
I've pushed a fixup to the branch to remove it, and I'll look into adding a
correct assertion later.
r~
next prev parent reply other threads:[~2020-06-05 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 12:04 another tst-arm-mte bug: qemu-system segfaults Szabolcs Nagy
2020-06-02 21:08 ` Richard Henderson
2020-06-02 21:58 ` Richard Henderson
2020-06-03 13:50 ` Szabolcs Nagy
2020-06-03 16:21 ` Richard Henderson
2020-06-03 17:17 ` Szabolcs Nagy
2020-06-05 20:26 ` Richard Henderson [this message]
2020-06-08 15:12 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0a8d9e-e8fc-6738-1851-74320585b7ab@linaro.org \
--to=richard.henderson@linaro.org \
--cc=nd@arm.com \
--cc=qemu-devel@nongnu.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).