Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile

[Thomas Huth <thuth@redhat.com>]

On 28/07/2022 08.52, Thomas Huth wrote:
> On 27/07/2022 18.36, Lucas Mateus Castro(alqotel) wrote:
>> Currently the run script uses 'readlink -e' but the image only has the
>> busybox readlink, this commit add the coreutils package which
>> contains the readlink with the '-e' option.
>>
>> Signed-off-by: Lucas Mateus Castro(alqotel) <lucas.araujo@eldorado.org.br>
>> ---
>>   tests/docker/dockerfiles/alpine.docker | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/docker/dockerfiles/alpine.docker 
>> b/tests/docker/dockerfiles/alpine.docker
>> index 3f4c0f95cb..2943a99730 100644
>> --- a/tests/docker/dockerfiles/alpine.docker
>> +++ b/tests/docker/dockerfiles/alpine.docker
>> @@ -21,6 +21,7 @@ RUN apk update && \
>>           cdrkit \
>>           ceph-dev \
>>           clang \
>> +        coreutils \
>>           ctags \
>>           curl-dev \
>>           cyrus-sasl-dev \
> 
> Not a good idea. If you look at the top of the file, you can see:
> 
> # THIS FILE WAS AUTO-GENERATED
> 
> So your modifications will be overwritten the next time someone runs the 
> lcitool.
> 
> I guess you'd need to modify tests/lcitool/projects/qemu.yml instead? Daniel?

Never mind, my e-mail program messed up the threading again, so I did not 
see that Daniel already replied.

  Thomas