From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 10/12] gdbstub: refactor get_feature_xml
Date: Tue, 29 Aug 2023 15:18:51 -0700 [thread overview]
Message-ID: <eb31a6e3-e709-21c6-a669-573eaf1a939c@linaro.org> (raw)
In-Reply-To: <20230829161528.2707696-11-alex.bennee@linaro.org>
On 8/29/23 09:15, Alex Bennée wrote:
> Try to bring up the code to more modern standards by:
>
> - use dynamic GString built xml over a fixed buffer
> - use autofree to save on explicit g_free() calls
> - don't hand hack strstr to find the delimiter
> - fix up style of xml_builtin and invert loop
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>
> ---
> v3
> - also clean-up xml_builtin loop
> - use strchr and defere copy for only xml case
> v2
> - avoid needless g_strndup for copy of annex
> ---
> gdbstub/internals.h | 2 +-
> gdbstub/gdbstub.c | 81 +++++++++++++++++++++++----------------------
> 2 files changed, 43 insertions(+), 40 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-08-29 23:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 16:15 [PATCH v3 00/12] gdbstub and testing fixes for 8.2 (pre-PR) Alex Bennée
2023-08-29 16:15 ` [PATCH v3 01/12] gitlab: enable ccache for many build jobs Alex Bennée
2023-08-29 16:15 ` [PATCH v3 02/12] tests/docker: cleanup non-verbose output Alex Bennée
2023-08-29 16:15 ` [PATCH v3 03/12] tests/tcg: remove quoting for info output Alex Bennée
2023-08-29 22:19 ` Richard Henderson
2023-08-29 16:15 ` [PATCH v3 04/12] docs/style: permit inline loop variables Alex Bennée
2023-08-29 16:15 ` [PATCH v3 05/12] .gitlab-ci.d/cirrus.yml: Update FreeBSD to v13.2 Alex Bennée
2023-08-29 16:15 ` [PATCH v3 06/12] tests: remove test-gdbstub.py Alex Bennée
2023-08-29 22:20 ` Richard Henderson
2023-08-29 16:15 ` [PATCH v3 07/12] tests/tcg: clean-up gdb confirm/pagination settings Alex Bennée
2023-08-29 16:15 ` [PATCH v3 08/12] gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT Alex Bennée
2023-08-29 16:15 ` [PATCH v3 09/12] gdbstub: remove unused user_ctx field Alex Bennée
2023-08-29 16:15 ` [PATCH v3 10/12] gdbstub: refactor get_feature_xml Alex Bennée
2023-08-29 22:18 ` Richard Henderson [this message]
2023-08-29 16:15 ` [PATCH v3 11/12] gdbstub: replace global gdb_has_xml with a function Alex Bennée
2023-08-29 16:15 ` [PATCH v3 12/12] gdbstub: move comment for gdb_register_coprocessor Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb31a6e3-e709-21c6-a669-573eaf1a939c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).