From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, eblake@redhat.com,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/mirror: check backing in bdrv_mirror_top_flush
Date: Fri, 29 Sep 2017 19:25:18 +0200 [thread overview]
Message-ID: <eb39b5cd-74c5-ffe5-7e1c-11cf7f6f2d46@redhat.com> (raw)
In-Reply-To: <20170929152255.5431-1-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On 2017-09-29 17:22, Vladimir Sementsov-Ogievskiy wrote:
> Backing may be zero after failed bdrv_append in mirror_start_job,
> which leads to SIGSEGV.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> similar SIGSEGV.
> looks like (I guess by code, don't have full back-trace because of
> coroutine switch on bdrv_flush):
> mirror_start_job,
> bdrv_append failed, backing is not set
> bdrv_unref
> bdrv_delete
> bdrv_close
> bdrv_flush
> ...
> bdrv_mirror_top_flush
> Segmentation fault on
> return bdrv_co_flush(bs->backing->bs);
> as bs->backing = 0
>
> block/mirror.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-09-29 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 12:03 [Qemu-devel] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename Vladimir Sementsov-Ogievskiy
2017-09-29 11:25 ` Max Reitz
2017-09-29 15:22 ` [Qemu-devel] [PATCH] block/mirror: check backing in bdrv_mirror_top_flush Vladimir Sementsov-Ogievskiy
2017-09-29 17:25 ` Max Reitz [this message]
2017-09-29 19:46 ` [Qemu-devel] [Qemu-block] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb39b5cd-74c5-ffe5-7e1c-11cf7f6f2d46@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).