From: Max Reitz <mreitz@redhat.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: backup_calculate_cluster_size does not consider source
Date: Wed, 6 Nov 2019 12:22:56 +0100 [thread overview]
Message-ID: <eb3a232d-6567-1816-b7fc-121770aa42b4@redhat.com> (raw)
In-Reply-To: <1868807950.27.1573039080274@webmail.proxmox.com>
[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]
On 06.11.19 12:18, Dietmar Maurer wrote:
>> And if it issues a smaller request, there is no way for a guest device
>> to tell it “OK, here’s your data, but note we have a whole 4 MB chunk
>> around it, maybe you’d like to take that as well...?”
>>
>> I understand wanting to increase the backup buffer size, but I don’t
>> quite understand why we’d want it to increase to the source cluster size
>> when the guest also has no idea what the source cluster size is.
>
> Because it is more efficent.
For rbd.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-06 11:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 10:02 backup_calculate_cluster_size does not consider source Dietmar Maurer
2019-11-06 8:32 ` Stefan Hajnoczi
2019-11-06 9:37 ` Max Reitz
2019-11-06 10:18 ` Dietmar Maurer
2019-11-06 10:37 ` Max Reitz
2019-11-06 10:34 ` Wolfgang Bumiller
2019-11-06 10:42 ` Max Reitz
2019-11-06 11:18 ` Dietmar Maurer
2019-11-06 11:22 ` Max Reitz [this message]
2019-11-06 11:37 ` Max Reitz
2019-11-06 13:09 ` Dietmar Maurer
2019-11-06 13:17 ` Max Reitz
2019-11-06 13:34 ` Dietmar Maurer
2019-11-06 13:52 ` Max Reitz
2019-11-06 14:39 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3a232d-6567-1816-b7fc-121770aa42b4@redhat.com \
--to=mreitz@redhat.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).