qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] target/arm: Log fault address for M-profile faults
Date: Tue, 15 Mar 2022 14:41:30 -0700	[thread overview]
Message-ID: <eb4fee59-8710-fc4f-f5f7-bfcf1131b9fd@linaro.org> (raw)
In-Reply-To: <20220315204306.2797684-3-peter.maydell@linaro.org>

On 3/15/22 13:43, Peter Maydell wrote:
> For M-profile, the fault address is not always exposed to the guest
> in a fault register (for instance the BFAR bus fault address register
> is only updated for bus faults on data accesses, not instruction
> accesses).  Currently we log the address only if we're putting it
> into a particular guest-visible register.  Since we always have it,
> log it generically, to make logs of i-side faults a bit clearer.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/m_helper.c | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2022-03-15 21:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 20:43 [PATCH 0/2] target/arm: Improve M-profile exception logging Peter Maydell
2022-03-15 20:43 ` [PATCH 1/2] target/arm: Log M-profile vector table accesses Peter Maydell
2022-03-15 21:40   ` Richard Henderson
2022-03-16 11:40   ` Alex Bennée
2022-03-15 20:43 ` [PATCH 2/2] target/arm: Log fault address for M-profile faults Peter Maydell
2022-03-15 21:41   ` Richard Henderson [this message]
2022-03-16 12:03   ` Alex Bennée
2022-03-16 13:00 ` [PATCH 0/2] target/arm: Improve M-profile exception logging Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb4fee59-8710-fc4f-f5f7-bfcf1131b9fd@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).