From: Paolo Bonzini <pbonzini@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>,
David Gibson <david@gibson.dropbear.id.au>
Cc: "Alexander Graf" <agraf@suse.de>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Pilippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations
Date: Thu, 5 Jul 2018 16:06:28 +0200 [thread overview]
Message-ID: <eb53939b-4a90-2e7b-32df-3dbe75169d3b@redhat.com> (raw)
In-Reply-To: <1530798684-23009-1-git-send-email-linux@roeck-us.net>
On 05/07/2018 15:51, Guenter Roeck wrote:
> + /* Failure to set serial port clocks is not fatal, so just ignore
> + * errors when trying to do so.
> + */
> + (void)fdt_setprop_cell(fdt, offset, "clock-frequency", UART_FREQ);
> offset = fdt_node_offset_by_compatible(fdt, offset, "ns16550");
Ok, but why would it even fail? Maybe it's not this case, but even if
it's not fatal for the OS, generating different device trees silently
seems like a recipe for Heisenbugs.
Thanks,
Paolo
next prev parent reply other threads:[~2018-07-05 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 13:51 [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations Guenter Roeck
2018-07-05 14:06 ` Paolo Bonzini [this message]
2018-07-06 1:18 ` David Gibson
2018-07-06 12:41 ` Paolo Bonzini
2018-07-07 21:23 ` Guenter Roeck
2018-07-09 3:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb53939b-4a90-2e7b-32df-3dbe75169d3b@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=linux@roeck-us.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).