From: Laszlo Ersek <lersek@redhat.com>
To: Jiahui Cen <cenjiahui@huawei.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: xieyingtai@huawei.com, Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
wu.wubin@huawei.com
Subject: Re: [PATCH v4 2/8] acpi: Fix unmatched expected DSDT.pxb file
Date: Thu, 14 Jan 2021 15:24:25 +0100 [thread overview]
Message-ID: <eb624354-98cd-eb9e-1f9f-f1095f25152a@redhat.com> (raw)
In-Reply-To: <2315137c-c6fc-8c6e-b0b4-122e8c3998d1@huawei.com>
On 01/14/21 02:30, Jiahui Cen wrote:
> Hi Michael,
>
> On 2021/1/13 22:00, Michael S. Tsirkin wrote:
>> On Thu, Jan 07, 2021 at 07:40:37PM +0800, Jiahui Cen wrote:
>>> Commit fe1127da11 ("unit-test: Add the binary file and clear diff.h") does not
>>> use the up-to-date expected file for pxb for ARM virt.
>>>
>>> Fix the expected DSDT.pxb file.
>>>
>>> Full diff of changed file disassembly:
>>>
>>> diff -ru /tmp/old/tests/data/acpi/virt/DSDT.pxb.dsl /tmp/new/tests/data/acpi/virt/DSDT.pxb.dsl
>>> --- /tmp/old/tests/data/acpi/virt/DSDT.pxb.dsl 2021-01-07 17:04:51.246831080 +0800
>>
>> This --- sign confuses git am. You shouldn't put this in the commit log
>> really ...
>>
>
> Yes, it does confuse. I found there were some patches with commit log
> like this, so I did the same :(
>
> So, I'll modify the commit logs and resend them.
It's OK to include diffs in the commit message or in the Notes section
of the patch, in general, but such diffs should always be indented, or
quoted in email-style (angle bracket on the left side), covering *all*
parts of the diff (headers, hunk headers, etc).
Laszlo
next prev parent reply other threads:[~2021-01-14 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 11:40 [PATCH v4 0/8] acpi: Some fixes for pxb support for ARM virt machine Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 1/8] acpi: Allow DSDT acpi table changes Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 2/8] acpi: Fix unmatched expected DSDT.pxb file Jiahui Cen
2021-01-13 14:00 ` Michael S. Tsirkin
2021-01-14 1:30 ` Jiahui Cen
2021-01-14 14:24 ` Laszlo Ersek [this message]
2021-01-07 11:40 ` [PATCH v4 3/8] acpi: Add addr offset in build_crs Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 4/8] acpi/gpex: Inform os to keep firmware resource map Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 5/8] acpi/gpex: Exclude pxb's resources from PCI0 Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 6/8] Kconfig: Compile PXB for ARM_VIRT Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 7/8] acpi: Enable pxb unit-test for ARM virt machine Jiahui Cen
2021-01-07 11:40 ` [PATCH v4 8/8] acpi: Update _DSM method in expected files Jiahui Cen
2021-01-12 10:19 ` [PATCH v4 0/8] acpi: Some fixes for pxb support for ARM virt machine Jiahui Cen
2021-01-12 10:37 ` Michael S. Tsirkin
2021-01-12 17:52 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb624354-98cd-eb9e-1f9f-f1095f25152a@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@arm.com \
--cc=cenjiahui@huawei.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wu.wubin@huawei.com \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).