Re: [Qemu-devel] [PATCH for-4.0] compiler.h: Add an explicit check for the compiler version

[Paolo Bonzini <pbonzini@redhat.com>]

On 30/11/18 13:30, Thomas Huth wrote:
> Do we really want to artificially limit our support here without any
> further reasons? If the users want to compile QEMU on an older system,
> and one of the libraries does not quite match anymore, it's often easy
> enough to recompile a newer version of the library to get things going
> again. Recompiling a whole compiler is way more cumbersome, though...
> 
> OTOH, we could get rid of some more #if QEMU_GNUC_PREREQ spots in the
> source code if we bump the minimum version to 4.8 ... so that might be a
> real reason to increase the minimum.

Of all of them, I think, if we bump to 4.7?

Older 4.6 and 4.7 version have the PR55489 bug that we're checking for
in configure, too ("we should be able to delete this at the end of 2013"
:)).  Bumping to 4.8 would let us remove TRANSLATE_OPT_CFLAGS for good.

Paolo

>> We would need an explicit check for clang, however, instead of
>> relying on it claiming gcc 4.2 support - that's a way inaccurate
>> claim anyway so detecting a specific clang version would be
>> better regardless IMHO
> 
> Fine for me if we bump the minimum Clang version to 3.4 ... then we
> could get rid of the the CONFIG_INT128 hacks that we have in various
> parts of the code.
> 
>  Thomas
>