Re: [PATCH v2 46/67] target/arm: Convert SQSHL and UQSHL (register) to gvec

[Richard Henderson <richard.henderson@linaro.org>]

On 5/28/24 08:53, Peter Maydell wrote:
> On Sat, 25 May 2024 at 00:28, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   target/arm/helper.h             |  8 ++++++++
>>   target/arm/tcg/translate.h      |  4 ++++
>>   target/arm/tcg/neon-dp.decode   | 10 ++-------
>>   target/arm/tcg/gengvec.c        | 24 ++++++++++++++++++++++
>>   target/arm/tcg/neon_helper.c    | 36 +++++++++++++++++++++++++++++++++
>>   target/arm/tcg/translate-a64.c  | 17 +++++++---------
>>   target/arm/tcg/translate-neon.c |  6 ++----
>>   7 files changed, 83 insertions(+), 22 deletions(-)
> 
> 
>> +#define NEON_GVEC_VOP2_ENV(name, vtype) \
>> +void HELPER(name)(void *vd, void *vn, void *vm, void *venv, uint32_t desc) \
>> +{                                                               \
>> +    intptr_t i, opr_sz = simd_oprsz(desc);                      \
>> +    vtype *d = vd, *n = vn, *m = vm;                            \
>> +    CPUARMState *env = venv;                                    \
>> +    for (i = 0; i < opr_sz / sizeof(vtype); i++) {              \
>> +        NEON_FN(d[i], n[i], m[i]);                              \
>> +    }                                                           \
>> +    clear_tail(d, opr_sz, simd_maxsz(desc));                    \
>> +}
>> +
> 
> Same question about H macros as for patch 44.

No H macros needed.


r~