qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] block/export/fuse.c: fix musl build
Date: Mon, 9 Aug 2021 17:29:53 +0200	[thread overview]
Message-ID: <ebbfad5c-fdfe-e77b-55da-bff5d8efca59@redhat.com> (raw)
In-Reply-To: <20210809095101.1101336-1-fontaine.fabrice@gmail.com>

On 09.08.21 11:51, Fabrice Fontaine wrote:
> Fix the following build failure on musl raised since version 6.0.0 and
> https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
> because musl does not define FALLOC_FL_ZERO_RANGE:
>
> ../block/export/fuse.c: In function 'fuse_fallocate':
> ../block/export/fuse.c:563:23: error: 'FALLOC_FL_ZERO_RANGE' undeclared (first use in this function)
>    563 |     } else if (mode & FALLOC_FL_ZERO_RANGE) {
>        |                       ^~~~~~~~~~~~~~~~~~~~
>
> Fixes:
>   - http://autobuild.buildroot.org/results/b96e3d364fd1f8bbfb18904a742e73327d308f64
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Philippe Mathieu-Daudé):
>   - Use CONFIG_FALLOCATE_ZERO_RANGE and make safer #ifdef'ry
>
>   block/export/fuse.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)

Thanks, applied to my block branch:

https://github.com/XanClic/qemu/commits/block

(Of note: I’ve had an email address change today, so sending the pull 
request may become a bit hairy.  If it doesn’t work out, I’ll have to 
ask Kevin (or Peter directly, given this is a build fix) tomorrow.)



      parent reply	other threads:[~2021-08-09 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  9:51 [PATCH v2] block/export/fuse.c: fix musl build Fabrice Fontaine
2021-08-09 10:27 ` [PATCH-for-6.1 " Philippe Mathieu-Daudé
2021-08-09 11:05   ` Denis V. Lunev
2021-08-09 15:29 ` Hanna Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebbfad5c-fdfe-e77b-55da-bff5d8efca59@redhat.com \
    --to=hreitz@redhat.com \
    --cc=fontaine.fabrice@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).