From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>,
npiggin@gmail.com, qemu-ppc@nongnu.org
Cc: danielhb413@gmail.com, clg@kaod.org, david@gibson.dropbear.id.au,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/2] ppc/spapr: Introduce SPAPR_NR_IPIS to refer IRQ range for CPU IPIs.
Date: Wed, 22 Nov 2023 12:13:58 +0100 [thread overview]
Message-ID: <ebc45ef8-1745-459d-a904-630d041c366e@linaro.org> (raw)
In-Reply-To: <20231122092845.973949-2-harshpb@linux.ibm.com>
Hi Harsh,
On 22/11/23 10:28, Harsh Prateek Bora wrote:
> spapr_irq_init currently uses existing macro SPAPR_XIRQ_BASE to refer to
> the range of CPU IPIs during initialization of nr-irqs property.
> It is more appropriate to have its own define which can be further
> reused as appropriate for correct interpretation.
>
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> Suggested-by: Cedric Le Goater <clg@kaod.org>
> ---
> hw/ppc/spapr_irq.c | 4 ++--
> include/hw/ppc/spapr_irq.h | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/include/hw/ppc/spapr_irq.h b/include/hw/ppc/spapr_irq.h
> index c22a72c9e2..e7a80a8349 100644
> --- a/include/hw/ppc/spapr_irq.h
> +++ b/include/hw/ppc/spapr_irq.h
> @@ -28,6 +28,7 @@
> #define SPAPR_IRQ_MSI (SPAPR_XIRQ_BASE + 0x0300)
>
> #define SPAPR_NR_XIRQS 0x1000
> +#define SPAPR_NR_IPIS 0x1000
BTW why hexadecimal and not decimal?
Regards,
Phil.
next prev parent reply other threads:[~2023-11-22 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:28 [PATCH RESEND v2 0/2] Introduce SPAPR_NR_IPIS and fix max-cpus Harsh Prateek Bora
2023-11-22 9:28 ` [PATCH v2 1/2] ppc/spapr: Introduce SPAPR_NR_IPIS to refer IRQ range for CPU IPIs Harsh Prateek Bora
2023-11-22 11:12 ` Philippe Mathieu-Daudé
2023-11-22 11:13 ` Philippe Mathieu-Daudé [this message]
2023-11-22 11:16 ` Cédric Le Goater
2023-11-22 11:31 ` Cédric Le Goater
2023-11-23 5:04 ` Harsh Prateek Bora
2023-11-22 9:28 ` [PATCH v2 2/2] ppc/spapr: Initialize max_cpus limit to SPAPR_NR_IPIS Harsh Prateek Bora
2023-11-22 11:16 ` Philippe Mathieu-Daudé
2023-11-23 5:03 ` Harsh Prateek Bora
2023-11-23 8:47 ` Cédric Le Goater
2023-11-23 10:26 ` Philippe Mathieu-Daudé
2023-11-23 13:51 ` Cédric Le Goater
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 9:24 [PATCH v2 1/2] ppc/spapr: Introduce SPAPR_NR_IPIS to refer IRQ range for CPU IPIs Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc45ef8-1745-459d-a904-630d041c366e@linaro.org \
--to=philmd@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).