Re: [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers

[Guenter Roeck <linux@roeck-us.net>]

On 2/7/20 5:09 AM, Joel Stanley wrote:
> On Fri, 7 Feb 2020 at 12:58, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 2/7/20 12:16 AM, Cédric Le Goater wrote:
>>> On 2/6/20 7:34 PM, Guenter Roeck wrote:
>>>> Initialize EHCI controllers on AST2400 and AST2500 using the existing
>>>> TYPE_PLATFORM_EHCI. After this change, booting ast2500-evb into Linux
>>>> successfully instantiates a USB interface.
>>>>
>>>> ehci-platform 1e6a3000.usb: EHCI Host Controller
>>>> ehci-platform 1e6a3000.usb: new USB bus registered, assigned bus number 1
>>>> ehci-platform 1e6a3000.usb: irq 21, io mem 0x1e6a3000
>>>> ehci-platform 1e6a3000.usb: USB 2.0 started, EHCI 1.00
>>>> usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.05
>>>> usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
>>>> usb usb1: Product: EHCI Host Controller
>>>
>>> Cool. Have you tried to plug any devices ?
>>>
>>
>> Yes, booting from USB drive works just fine. I already added it to my
>> test suite at kerneltests.org.
> 
> Nice!
> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 
>>> This looks good. Could you add the AST2600 also ?
>>>
>>
>> I thought about that, but how would I test it ? None of the ast2600
>> systems in the Linux kernel enables it. The devicetree include file for
>> ast2600 doesn't even have an entry for it. I could cook something up,
>> but that would not reflect real hardware.
> 
> FYI, there are patches on the linux-aspeed list to enable USB:
> 
>   https://patchwork.ozlabs.org/project/linux-aspeed/list/?series=156260
> 
> They have not yet been merged into the kernel, but I will merge the
> device tree changes once -rc1 is out.
> 

Excellent. With the above series, and after enabling ehci1 for ast2600-evb
and adding the necessary code to qemu, I get

ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
ehci-platform: EHCI generic platform driver
ehci-platform 1e6a3000.usb: EHCI Host Controller
ehci-platform 1e6a3000.usb: new USB bus registered, assigned bus number 1
ehci-platform 1e6a3000.usb: irq 25, io mem 0x1e6a3000
ehci-platform 1e6a3000.usb: USB 2.0 started, EHCI 1.00
usb usb1: Manufacturer: Linux 5.5.0-09825-ga0802f2d0ef5-dirty ehci_hcd

and I can mount a USB drive. Is that good enough for a follow-up patch,
or should I wait until the code finds its way into the Linux kernel ?

Thanks,
Guenter