From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Claudio Fontana <cfontana@suse.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Pavel Dovgalyuk" <dovgaluk@ispras.ru>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 0/3] unbreak non-tcg builds
Date: Tue, 13 Oct 2020 10:50:34 +0200 [thread overview]
Message-ID: <ebd66974-280e-1ce0-54c1-cb3fc2ab6016@redhat.com> (raw)
In-Reply-To: <4b561396-f6ea-599f-1108-8fc679f61c31@suse.de>
On 10/13/20 10:28 AM, Claudio Fontana wrote:
> On 10/13/20 10:25 AM, Philippe Mathieu-Daudé wrote:
>> On 10/12/20 11:45 PM, Claudio Fontana wrote:
>>> This series now unbreaks current non-tcg builds
>>> (!CONFIG_TCG).
>>>
>>> tests Makefiles need to avoid relying on all non-native
>>> archs binaries to be present,
>>>
>>> bios-tables-test needs to skip tests that are tcg-only,
>>>
>>> and notably the replay framework needs to consider that
>>> it might not be functional (or its code present at all)
>>> without TCG.
>>>
>>> Tested ok target x86_64-softmmu on x86_64 host with:
>>>
>>> ./configure --enable-tcg --disable-kvm
>>> ./configure --enable-kvm --disable-tcg
>>> ./configure --enable-tcg --enable-kvm
>>>
>>> running make check-qtest
>>
>> If you want to avoid these configurations to bitrot,
>> please cover them adding Gitlab jobs.
>>
>> Thanks,
>>
>> Phil.
>>
>
> Hi, yes I was about to ask :-) We have only minimal coverage of --disable-tcg and only for s390 IIRC.
Aarch64 is on his way:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg746053.html
>
> Ciao,
>
> Claudio
>
prev parent reply other threads:[~2020-10-13 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 21:45 [PATCH v2 0/3] unbreak non-tcg builds Claudio Fontana
2020-10-12 21:45 ` [PATCH v2 1/3] tests/Makefile.include: " Claudio Fontana
2020-10-12 21:45 ` [PATCH v2 2/3] qtest: unbreak non-TCG builds in bios-tables-test Claudio Fontana
2020-10-12 21:45 ` [PATCH v2 3/3] replay: do not build if TCG is not available Claudio Fontana
2020-10-12 22:29 ` Paolo Bonzini
2020-10-13 7:56 ` Claudio Fontana
2020-10-13 8:05 ` Paolo Bonzini
2020-10-13 8:24 ` Claudio Fontana
2020-10-13 8:25 ` [PATCH v2 0/3] unbreak non-tcg builds Philippe Mathieu-Daudé
2020-10-13 8:28 ` Claudio Fontana
2020-10-13 8:50 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd66974-280e-1ce0-54c1-cb3fc2ab6016@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).