From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods
Date: Fri, 12 Apr 2024 10:27:18 -0700 [thread overview]
Message-ID: <ebe85e8f-1dc5-475c-8851-a333f38e795f@linaro.org> (raw)
In-Reply-To: <20240412160809.1260625-5-peter.maydell@linaro.org>
On 4/12/24 09:08, Peter Maydell wrote:
> We pass a ResetType argument to the Resettable class enter
> phase method, but we don't pass it to hold and exit, even though
> the callsites have it readily available. This means that if
> a device cared about the ResetType it would need to record it
> in the enter phase method to use later on. Pass the type to
> all three of the phase methods to avoid having to do that.
>
> Commit created with
>
> for dir in hw target include; do \
> spatch --macro-file scripts/cocci-macro-file.h \
> --sp-file scripts/coccinelle/reset-type.cocci \
> --keep-comments --smpl-spacing --in-place \
> --include-headers --dir $dir; done
>
> and no manual edits.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-04-12 17:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 16:08 [PATCH 0/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD Peter Maydell
2024-04-12 16:08 ` [PATCH 1/6] hw/misc: Don't special case RESET_TYPE_COLD in npcm7xx_clk, gcr Peter Maydell
2024-04-12 17:21 ` Richard Henderson
2024-04-12 17:32 ` Philippe Mathieu-Daudé
2024-04-16 9:08 ` Luc Michel
2024-04-12 16:08 ` [PATCH 2/6] allwinner-i2c, adm1272: Use device_cold_reset() for software-triggered reset Peter Maydell
2024-04-12 17:22 ` Richard Henderson
2024-04-16 9:09 ` Luc Michel
2024-04-12 16:08 ` [PATCH 3/6] scripts/coccinelle: New script to add ResetType to hold and exit phases Peter Maydell
2024-04-16 9:10 ` Luc Michel
2024-04-12 16:08 ` [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods Peter Maydell
2024-04-12 16:49 ` Edgar E. Iglesias
2024-04-12 17:27 ` Richard Henderson [this message]
2024-04-16 9:10 ` Luc Michel
2024-04-12 16:08 ` [PATCH 5/6] docs/devel/reset: Update to new API for " Peter Maydell
2024-04-12 17:27 ` Richard Henderson
2024-04-12 17:29 ` Philippe Mathieu-Daudé
2024-04-16 9:10 ` Luc Michel
2024-04-12 16:08 ` [PATCH 6/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD Peter Maydell
2024-04-12 17:30 ` Richard Henderson
2024-04-12 17:31 ` Philippe Mathieu-Daudé
2024-04-16 9:21 ` Luc Michel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe85e8f-1dc5-475c-8851-a333f38e795f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).