From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, berrange@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive
Date: Wed, 26 Jun 2019 17:18:31 -0400 [thread overview]
Message-ID: <ebef5b9b-d2e9-7097-de61-9213fcb3f4e1@redhat.com> (raw)
In-Reply-To: <20190605161804.118956-1-vsementsov@virtuozzo.com>
On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here is a suggestion to enable keepalive option to track server availablity.
> We suggest to enable it by default. If we need, we'll be able to add option
> to specify timeout by hand later.
>
> v2: 01 - Fix io channel returned errors to be -1 [Daniel]
> 02 - Fix typo in commit message [Eric]
>
> Vladimir Sementsov-Ogievskiy (2):
> io/channel: add qio_channel_set_keepalive
> nbd-client: enable TCP keepalive
>
> include/io/channel.h | 15 +++++++++++++++
> block/nbd-client.c | 1 +
> io/channel-socket.c | 20 ++++++++++++++++++++
> io/channel.c | 14 ++++++++++++++
> 4 files changed, 50 insertions(+)
>
Ping -- I think this was good to go with Dan's ACK, based on the
discussion from v1.
next prev parent reply other threads:[~2019-06-26 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 16:18 [Qemu-devel] [PATCH v2 0/2] nbd: enable keepalive Vladimir Sementsov-Ogievskiy
2019-06-05 16:18 ` [Qemu-devel] [PATCH v2 1/2] io/channel: add qio_channel_set_keepalive Vladimir Sementsov-Ogievskiy
2019-06-05 16:29 ` Daniel P. Berrangé
2019-06-05 16:18 ` [Qemu-devel] [PATCH v2 2/2] nbd-client: enable TCP keepalive Vladimir Sementsov-Ogievskiy
2019-06-26 21:18 ` John Snow [this message]
2019-06-26 21:23 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive Eric Blake
2019-06-26 21:24 ` John Snow
2019-06-26 21:24 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebef5b9b-d2e9-7097-de61-9213fcb3f4e1@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).