From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, berrange@redhat.com, peter.maydell@linaro.org,
pbonzini@redhat.com
Subject: Re: [PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array()
Date: Thu, 9 Nov 2023 20:11:30 +0100 [thread overview]
Message-ID: <ebfa35fd-595b-4f30-9fd2-895d8bf5d52b@linaro.org> (raw)
In-Reply-To: <20231109174240.72376-2-kwolf@redhat.com>
On 9/11/23 18:42, Kevin Wolf wrote:
> Instead of manually setting "foo-len" and "foo[i]" properties, build a
> QList and use the new qdev_prop_set_array() helper to set the whole
> array property with a single call.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/i386/pc.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-11-09 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:42 [PATCH v3 00/11] qdev: Make array properties user accessible again Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array() Kevin Wolf
2023-11-09 19:11 ` Philippe Mathieu-Daudé [this message]
2023-11-09 17:42 ` [PATCH v3 02/11] hw/arm/mps2-tz: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 03/11] hw/arm/mps2: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 04/11] hw/arm/sbsa-ref: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 05/11] hw/arm/vexpress: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 06/11] hw/arm/virt: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 07/11] hw/arm/xlnx-versal: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 08/11] hw/rx/rx62n: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 09/11] qom: Add object_property_set_default_list() Kevin Wolf
2023-11-09 19:12 ` Philippe Mathieu-Daudé
2023-11-09 17:42 ` [PATCH v3 10/11] qdev: Make netdev properties work as list elements Kevin Wolf
2023-11-09 19:13 ` Philippe Mathieu-Daudé
2023-11-09 17:42 ` [PATCH v3 11/11] qdev: Rework array properties based on list visitor Kevin Wolf
2023-11-09 19:14 ` [PATCH v3 00/11] qdev: Make array properties user accessible again Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebfa35fd-595b-4f30-9fd2-895d8bf5d52b@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).