From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8696DC4332F for ; Thu, 9 Nov 2023 19:11:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1ARE-0001B5-5x; Thu, 09 Nov 2023 14:11:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1ARC-00019j-OM for qemu-devel@nongnu.org; Thu, 09 Nov 2023 14:11:34 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1ARB-0001vC-7M for qemu-devel@nongnu.org; Thu, 09 Nov 2023 14:11:34 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-53e751aeb3cso1941078a12.2 for ; Thu, 09 Nov 2023 11:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699557092; x=1700161892; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4K68xf8NAjNggL6wjAW9d2As5hNmQ2lG2+eujmVb0VQ=; b=PmzVGZdO73PxHqYXZCFtigNWXRiUXzjUcvPAnUXW70Xc0jamJLhFVgvplLApP2uNDW qAKN/H8SzlcyeL5lLq2TgQc5GMCoy7XIsKj3Ct7LrQHkicqeQRekQ6S66Him5AUUIaBz IWwi7IwJP7DyNkLnGLOP7xf/Ij2SfQuS2vYaYYSTItmD168DGF7yYMBXmAk0OVpP79Xk cQ+iT/2E2spRgmlSjFNlAcFta/9N/bGVaS5LkI9MbhP0H6dC59nhU8UqmfBC1H+jFjox KjEppmHXLNQZtC5sqE2kUIoYhZpd8pPhP7nIvlgvdsrtmvPKGQWa5T4oEGOCtXOmRER5 RH4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699557092; x=1700161892; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4K68xf8NAjNggL6wjAW9d2As5hNmQ2lG2+eujmVb0VQ=; b=sfObAh6+vDaGrTyNAiBXOsTlKAhpjG89wwqUbuAJ1aY+TPKqjHaJs8sYYk5VX7rc+g n8B8iKaDFLJO6VvVHvW0SaMEB90docMriTCqDKGRzL12izwzTpfxVtCVa1IKnT4rDrRK lMWD5WUgbtlJYWCypcDPnT865+/6mT2QmHI42RG+sat6D7BEb9535n/OuKl0G/hnQVaP n5IXocTFf40z9Cj+nw+7ZR8zk7Fmv9mEc3YFAAIdPoJkbRiXUaWl9Q0YBzJuEOXpB0Sh dmpslUEhzZABWX8WPtt2yvCLZ3fjvHpdJx+nB9aju8HLu1TJHeKfx75FBHDJZapiYt1b Cc0w== X-Gm-Message-State: AOJu0Yyo5CTcRpAalqOu3K2t8EoJ44iwFmcC3qNAGC/v3EL11SJixWgH kEqaFvJw9n+Dr0UvZoIRKJWVCw== X-Google-Smtp-Source: AGHT+IG26E6p4hp3Cz7qxfj3R2pUcr4PDuMtPjNBC04aR3Y9cuvWXUYmSj7t7nDDnT2ZQMdVbVIjJw== X-Received: by 2002:a50:875a:0:b0:53e:e6eb:c838 with SMTP id 26-20020a50875a000000b0053ee6ebc838mr5158486edv.8.1699557091803; Thu, 09 Nov 2023 11:11:31 -0800 (PST) Received: from [192.168.69.115] ([176.187.199.161]) by smtp.gmail.com with ESMTPSA id d4-20020a056402516400b0052febc781bfsm166756ede.36.2023.11.09.11.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 11:11:31 -0800 (PST) Message-ID: Date: Thu, 9 Nov 2023 20:11:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array() Content-Language: en-US To: Kevin Wolf , qemu-devel@nongnu.org Cc: armbru@redhat.com, berrange@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com References: <20231109174240.72376-1-kwolf@redhat.com> <20231109174240.72376-2-kwolf@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20231109174240.72376-2-kwolf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=philmd@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/11/23 18:42, Kevin Wolf wrote: > Instead of manually setting "foo-len" and "foo[i]" properties, build a > QList and use the new qdev_prop_set_array() helper to set the whole > array property with a single call. > > Signed-off-by: Kevin Wolf > Reviewed-by: Peter Maydell > --- > hw/i386/pc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé