Re: [PATCH 0/2] target/arm: Always build Aarch64 gdbstub helpers

[Richard Henderson <richard.henderson@linaro.org>]

On 6/28/24 09:37, Philippe Mathieu-Daudé wrote:
> On 28/6/24 16:31, Richard Henderson wrote:
>> On 6/19/24 05:49, Philippe Mathieu-Daudé wrote:
>>> Merge gdbstub64.c in gdbstub.c and remove uses of
>>> target specific TARGET_AARCH64 definition.
>>> Small step toward single ARM/Aarch64 binary.
>>>
>>> Philippe Mathieu-Daudé (2):
>>>    target/arm: Merge gdbstub64.c within gdbstub.c
>>>    target/arm: Always build Aarch64 gdbstub helpers
>>>
>>>   target/arm/cpu.h       |   8 +-
>>>   target/arm/internals.h |   2 -
>>>   target/arm/gdbstub.c   | 363 +++++++++++++++++++++++++++++++++++++-
>>>   target/arm/gdbstub64.c | 383 -----------------------------------------
>>>   target/arm/meson.build |   1 -
>>>   5 files changed, 364 insertions(+), 393 deletions(-)
>>>   delete mode 100644 target/arm/gdbstub64.c
>>>
>>
>> Are we attempting a single binary for user-only as well?
> 
> No, due to ABI constraints, right? I did a user-emulation
> smoke build, no failure, did I miss something?

Well, no.  But qemu-arm does not need gdbstub64.c.
Given TARGET_AARCH64 will be set on a combined build, I'm not sure what is the fix?


r~