From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: agraf@suse.de, Aurelien Jarno <aurelien@aurel32.net>,
thuth@redhat.com, Miroslav Benes <mbenes@suse.cz>
Subject: Re: [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model
Date: Wed, 14 Jun 2017 09:03:11 +0200 [thread overview]
Message-ID: <ec1668df-7098-62b9-a3b6-b79cac8f224d@redhat.com> (raw)
In-Reply-To: <e1193b07-a074-140d-c44b-c122d6909c12@twiddle.net>
On 14.06.2017 06:44, Richard Henderson wrote:
> On 06/13/2017 02:47 PM, David Hildenbrand wrote:
>> + if (!s390_has_feat(S390_FEAT_MOVE_WITH_OPTIONAL_SPEC)) {
>> + program_interrupt(env, PGM_OPERATION, 6);
>> + }
>
> This is (supposed to be) done via the feature field of insn-data.def.
>
> Except that we do not yet enforce that; we haven't updated that bit of the
> translator since we actually added support for the feature bits.
That makes sense, I'll drop this hunk then. So wiring up these bits with
the CPU model directly sounds like what we want to do.
Thanks!
>
>
> r~
>
--
Thanks,
David
next prev parent reply other threads:[~2017-06-14 7:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 21:47 [Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it David Hildenbrand
2017-06-13 21:47 ` [Qemu-devel] [PATCH v1 1/3] target/s390x: change PSW_SHIFT_KEY David Hildenbrand
2017-06-14 7:05 ` Thomas Huth
2017-06-13 21:47 ` [Qemu-devel] [PATCH v1 2/3] target/s390x: implement mvcos instruction David Hildenbrand
2017-06-14 4:41 ` Richard Henderson
2017-06-14 7:22 ` David Hildenbrand
2017-06-14 14:30 ` Richard Henderson
2017-06-14 17:02 ` David Hildenbrand
2017-06-14 7:37 ` Thomas Huth
2017-06-14 7:56 ` David Hildenbrand
2017-06-14 20:00 ` Thomas Huth
2017-06-14 23:44 ` Richard Henderson
2017-06-13 21:47 ` [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model David Hildenbrand
2017-06-14 4:44 ` Richard Henderson
2017-06-14 7:03 ` David Hildenbrand [this message]
2017-06-14 7:40 ` Thomas Huth
2017-06-13 21:57 ` [Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1668df-7098-62b9-a3b6-b79cac8f224d@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=mbenes@suse.cz \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).