From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL2Km-0001Tp-9c for qemu-devel@nongnu.org; Wed, 14 Jun 2017 03:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dL2Ki-0001rJ-CQ for qemu-devel@nongnu.org; Wed, 14 Jun 2017 03:03:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50472) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dL2Ki-0001rB-6M for qemu-devel@nongnu.org; Wed, 14 Jun 2017 03:03:16 -0400 References: <20170613214736.19963-1-david@redhat.com> <20170613214736.19963-4-david@redhat.com> From: David Hildenbrand Message-ID: Date: Wed, 14 Jun 2017 09:03:11 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: agraf@suse.de, Aurelien Jarno , thuth@redhat.com, Miroslav Benes On 14.06.2017 06:44, Richard Henderson wrote: > On 06/13/2017 02:47 PM, David Hildenbrand wrote: >> + if (!s390_has_feat(S390_FEAT_MOVE_WITH_OPTIONAL_SPEC)) { >> + program_interrupt(env, PGM_OPERATION, 6); >> + } > > This is (supposed to be) done via the feature field of insn-data.def. > > Except that we do not yet enforce that; we haven't updated that bit of the > translator since we actually added support for the feature bits. That makes sense, I'll drop this hunk then. So wiring up these bits with the CPU model directly sounds like what we want to do. Thanks! > > > r~ > -- Thanks, David