qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	richard.henderson@linaro.org,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH] hw/hppa/Kconfig: LASI chipset requires PARALLEL port
Date: Wed, 29 Jan 2020 22:41:12 +0100	[thread overview]
Message-ID: <ec1fed8a-c099-83bd-d64b-bc29a0b9eb2b@gmx.de> (raw)
In-Reply-To: <20200129192350.27143-1-philmd@redhat.com>

On 29.01.20 20:23, Philippe Mathieu-Daudé wrote:
> The PARISC Lasi chipset emulation requires some of the common parallel
> support and fails to build on a --without-default-devices:
>
>     LINK    hppa-softmmu/qemu-system-hppa
>   /usr/bin/ld: hw/hppa/lasi.o: in function `lasi_init':
>   hw/hppa/lasi.c:324: undefined reference to `parallel_mm_init'
>   collect2: error: ld returned 1 exit status
>   make[1]: *** [Makefile:206: qemu-system-hppa] Error 1
>
> Fixes: 376b851909d
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Acked-by: Helge Deller <deller@gmx.de>

> ---
>  hw/hppa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
> index 82178c7dcb..22948db025 100644
> --- a/hw/hppa/Kconfig
> +++ b/hw/hppa/Kconfig
> @@ -12,4 +12,5 @@ config DINO
>      select LSI_SCSI_PCI
>      select LASI_82596
>      select LASIPS2
> +    select PARALLEL
>      select ARTIST
>



      reply	other threads:[~2020-01-29 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 19:23 [PATCH] hw/hppa/Kconfig: LASI chipset requires PARALLEL port Philippe Mathieu-Daudé
2020-01-29 21:41 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec1fed8a-c099-83bd-d64b-bc29a0b9eb2b@gmx.de \
    --to=deller@gmx.de \
    --cc=alex.bennee@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).