From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B982C433DB for ; Mon, 22 Feb 2021 08:33:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98D2C64E5F for ; Mon, 22 Feb 2021 08:33:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98D2C64E5F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lE6eN-0000aG-Hk for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 03:33:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lE6ce-0007NC-SI for qemu-devel@nongnu.org; Mon, 22 Feb 2021 03:31:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:57108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lE6cc-0008Gg-VP for qemu-devel@nongnu.org; Mon, 22 Feb 2021 03:31:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 56D00AF85; Mon, 22 Feb 2021 08:31:13 +0000 (UTC) Subject: Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG To: Richard Henderson References: <20210221092449.7545-1-cfontana@suse.de> <20210221092449.7545-6-cfontana@suse.de> <38cb9c63-1138-2081-933e-03f6997a50fe@linaro.org> From: Claudio Fontana Message-ID: Date: Mon, 22 Feb 2021 09:31:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <38cb9c63-1138-2081-933e-03f6997a50fe@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/22/21 7:21 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> { >> CPUClass *cc = CPU_GET_CLASS(cs); >> @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> cc->tcg_ops->do_interrupt(cs); >> return true; >> } >> +#endif /* CONFIG_TCG */ > > I presume this function gets moved later? What does this aid in the interim? > > > r~ > Hi Richard, actually this is a fix for an error I introduced when adding TCGOps: arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, which is TCG-only. Maybe I should extract this and make it a standalone fix. Currently, there is no real issue because the non-TCG build is not working for ARM anyway, and that's why the issue went undetected. Thanks! Claudio