From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH 2/2] target/i386: fix memory operand size for CVTPS2PD
Date: Tue, 29 Aug 2023 10:36:23 -0700 [thread overview]
Message-ID: <ec3067fc-f654-4e63-b99a-5b22a765ba87@linaro.org> (raw)
In-Reply-To: <20230829165304.114948-3-pbonzini@redhat.com>
On 8/29/23 09:53, Paolo Bonzini wrote:
> CVTPS2PD only loads a half-register for memory, unlike the other
> operations under 0x0F 0x5A. "Unpack" the group into separate
> emission functions instead of using gen_unary_fp_sse.
>
> Cc:qemu-stable@nongnu.org
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/1377
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target/i386/tcg/decode-new.c.inc | 14 ++++++++++++--
> target/i386/tcg/emit.c.inc | 30 +++++++++++++++++++++++++-----
> 2 files changed, 37
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-08-29 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 16:53 [PATCH 0/2] target/i386: reimplement fp2fp conversion instructions Paolo Bonzini
2023-08-29 16:53 ` [PATCH 1/2] target/i386: generalize operand size "ph" for use in CVTPS2PD Paolo Bonzini
2023-08-29 17:32 ` Richard Henderson
2023-08-29 16:53 ` [PATCH 2/2] target/i386: fix memory operand size for CVTPS2PD Paolo Bonzini
2023-08-29 17:36 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3067fc-f654-4e63-b99a-5b22a765ba87@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).