qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	Vadim Rozenfeld <vrozenfe@redhat.com>
Cc: Hangaohuai <hangaohuai@huawei.com>,
	Yan Vugenfirer <yvugenfi@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Radim Krcmar <rkrcmar@redhat.com>
Subject: Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts
Date: Mon, 20 Feb 2017 13:57:17 +0100	[thread overview]
Message-ID: <ec45f714-66f7-ba93-70c2-e2a033ad4ccd@redhat.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020DA1C1608@DGGEMA505-MBX.china.huawei.com>



On 20/02/2017 12:54, Gonglei (Arei) wrote:
>>
>> On 20/02/2017 10:19, Gonglei (Arei) wrote:
>>> Hi Paolo,
>>>
>>>>
>>>>
>>>> On 16/02/2017 02:31, Gonglei (Arei) wrote:
>>>>> And the below patch works for me, I can support max 255 vcpus for
>> WS2012
>>>>> with hyper-v enlightenments.
>>>>>
>>>>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>>>>> index 27fd050..efe3cbc 100644
>>>>> --- a/target/i386/kvm.c
>>>>> +++ b/target/i386/kvm.c
>>>>> @@ -772,7 +772,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>>>>>
>>>>>          c = &cpuid_data.entries[cpuid_i++];
>>>>>          c->function = HYPERV_CPUID_IMPLEMENT_LIMITS;
>>>>> -        c->eax = 0x40;
>>>>> +        c->eax = -1;
>>>>>          c->ebx = 0x40;
>>>>>
>>>>>          kvm_base = KVM_CPUID_SIGNATURE_NEXT;
>>>>
>>>> This needs to depend on the machine type, but apart from that I think
>>>
>>> I don't know why. Because the negative effects for this change don't exist
>>> on current QEMU IIUC, and we don't have compatible problems for live
>> migration.
>>
>> CPUID should never change with the same machine type and command line.
>>
> OK, then how do we add compat code for the CPUID change? It's not a visible property.

You can add a new property, something like hv-cpuid-limits-eax.

Paolo

  reply	other threads:[~2017-02-20 12:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09  6:18 [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts hangaohuai
2017-02-09 12:17 ` Yan Vugenfirer
2017-02-10  9:31   ` Gonglei (Arei)
2017-02-10 12:01     ` Paolo Bonzini
2017-02-11 10:12       ` Gonglei (Arei)
2017-02-11 15:39         ` Paolo Bonzini
2017-02-13 10:05           ` Vadim Rozenfeld
2017-02-16  1:31             ` Gonglei (Arei)
2017-02-16  6:26               ` Vadim Rozenfeld
2017-02-17 11:21               ` Paolo Bonzini
2017-02-20  9:19                 ` Gonglei (Arei)
2017-02-20 11:06                   ` Paolo Bonzini
2017-02-20 11:54                     ` Gonglei (Arei)
2017-02-20 12:57                       ` Paolo Bonzini [this message]
2017-02-20 13:18                         ` Gonglei (Arei)
2017-09-05  6:33                           ` Vadim Rozenfeld
2017-09-05  7:51                             ` Gonglei (Arei)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec45f714-66f7-ba93-70c2-e2a033ad4ccd@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=hangaohuai@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=vrozenfe@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).