Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

[Emanuele <e.emanuelegiuseppe@gmail.com>]

On 07/18/2018 04:23 PM, Stefan Hajnoczi wrote:
> On Wed, Jul 11, 2018 at 04:58:41PM +0200, Paolo Bonzini wrote:
>> On 11/07/2018 16:28, Stefan Hajnoczi wrote:
>>>> + *
>>>> + * QOSGraphObject also provides a destructor, used to deallocate the
>>>> + * after the test has been executed.
>>>> + */
>>>> +struct QOSGraphObject {
>>>> +    /* for produces, returns void * */
>>>> +    QOSGetDriver get_driver;
>>> Unused?
>>>
>>>> +    /* for contains, returns a QOSGraphObject * */
>>>> +    QOSGetDevice get_device;
>>> Unused?
>> What is unused?
> Neither of these fields are used in this patch.  Please introduce them
> in the first patch that actually uses them.  This way code review can
> proceed linearly and it also prevents deadcode when just part of a patch
> series is merged or backported.
I'm sorry but at this point also sdhci.c, raspi2-machine.c and 
x86_64_pc-machine.c (patch 3-4-5) are not actually even compiled before 
qos-test.c (patch 6). Is that wrong too?