From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Tomasz Dzieciol <t.dzieciol@partner.samsung.com>, qemu-devel@nongnu.org
Cc: sriram.yagnaraman@est.tech, jasowang@redhat.com,
k.kwiecien@samsung.com, m.sochacki@samsung.com
Subject: Re: [PATCH v8 0/7] igb: packet-split descriptors support
Date: Tue, 23 May 2023 11:50:34 +0900 [thread overview]
Message-ID: <ec4fa2b0-deb2-4e94-86eb-f1668cbef934@daynix.com> (raw)
In-Reply-To: <20230518140448.2001-1-t.dzieciol@partner.samsung.com>
On 2023/05/18 23:04, Tomasz Dzieciol wrote:
> Based-on: <20230423041833.5302-1-akihiko.odaki@daynix.com>
> ("[PATCH v3 00/47] igb: Fix for DPDK")
>
> Purposes of this series of patches:
> * introduce packet-split RX descriptors support. This feature is used by Linux
> VF driver for MTU values from 2048.
> * refactor RX descriptor handling for introduction of packet-split RX
> descriptors support
> * fix descriptors flags handling
>
> Tomasz Dzieciol (7):
> igb: remove TCP ACK detection
> igb: rename E1000E_RingInfo_st
> igb: RX descriptors guest writting refactoring
> igb: RX payload guest writting refactoring
> igb: add IPv6 extended headers traffic detection
> igb: packet-split descriptors support
> e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers
>
> hw/net/e1000e_core.c | 78 ++--
> hw/net/igb_core.c | 746 ++++++++++++++++++++++++++++-----------
> hw/net/igb_regs.h | 20 +-
> hw/net/trace-events | 6 +-
> tests/qtest/libqos/igb.c | 5 +
> 5 files changed, 604 insertions(+), 251 deletions(-)
>
Hi,
Finally I decided to test your patches, and found some problems in them
*and* my series this is based on. Please rebase your series to
"[PATCH v5 00/48] igb: Fix for DPDK" which I have just sent, and review
comments I'll give for patches.
Regards,
Akihiko Odaki
prev parent reply other threads:[~2023-05-23 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230518140457eucas1p17f5acf26efb84441f8da0510ffd38bab@eucas1p1.samsung.com>
2023-05-18 14:04 ` [PATCH v8 0/7] igb: packet-split descriptors support Tomasz Dzieciol
[not found] ` <CGME20230518140457eucas1p21b5db6f35c3f2c77081eeaf1779ce3ab@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 1/7] igb: remove TCP ACK detection Tomasz Dzieciol
[not found] ` <CGME20230518140458eucas1p27f3f11d5b4572148675bfd08b485813f@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 2/7] igb: rename E1000E_RingInfo_st Tomasz Dzieciol
[not found] ` <CGME20230518140458eucas1p200bea061f622857ab8aa5140b9130515@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 3/7] igb: RX descriptors guest writting refactoring Tomasz Dzieciol
2023-05-23 2:50 ` Akihiko Odaki
[not found] ` <CGME20230518140459eucas1p2dafa81561d57fe5aad7d39f786e193f7@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 4/7] igb: RX payload " Tomasz Dzieciol
2023-05-23 2:51 ` Akihiko Odaki
[not found] ` <CGME20230518140459eucas1p24761544eb4d24535fa1e8402925817a0@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 5/7] igb: add IPv6 extended headers traffic detection Tomasz Dzieciol
[not found] ` <CGME20230518140500eucas1p247a4d2921b5d5ddabf93b8bd06ac5776@eucas1p2.samsung.com>
2023-05-18 14:04 ` [PATCH v8 6/7] igb: packet-split descriptors support Tomasz Dzieciol
[not found] ` <CGME20230518140500eucas1p1f92e6605c8a68a68d564ef5ad5de66dd@eucas1p1.samsung.com>
2023-05-18 14:04 ` [PATCH v8 7/7] e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers Tomasz Dzieciol
2023-05-23 2:50 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec4fa2b0-deb2-4e94-86eb-f1668cbef934@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=jasowang@redhat.com \
--cc=k.kwiecien@samsung.com \
--cc=m.sochacki@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
--cc=t.dzieciol@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).