From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGNfp-00018t-VI for qemu-devel@nongnu.org; Wed, 09 May 2018 07:54:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGNfm-0007pl-Ug for qemu-devel@nongnu.org; Wed, 09 May 2018 07:54:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33986 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGNfm-0007oK-PG for qemu-devel@nongnu.org; Wed, 09 May 2018 07:54:18 -0400 References: <20180413075200.15217-1-clg@kaod.org> <20180419165800.GA2731@work-vm> <20180509110833.GD2527@work-vm> From: Paolo Bonzini Message-ID: Date: Wed, 9 May 2018 13:54:10 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Dr. David Alan Gilbert" Cc: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , QEMU Developers , Juan Quintela , David Gibson , Alex Williamson , Yulei Zhang , "Tian, Kevin" , joonas.lahtinen@linux.intel.com, zhenyuw@linux.intel.com, Kirti Wankhede , zhi.a.wang@intel.com, Paul Burton , Aurelien Jarno , Yongbok Kim On 09/05/2018 13:33, Peter Maydell wrote: > > I don't think we need to fix those first, but: > > * we should note in the commit message for this patch that > it is a de-facto migration break for those boards > * we should fix those devices/boards in this release cycle, > since we've broken migration compat anyway > * we should check with the MIPS maintainers that they're ok > with a cross-version migration compat break for those boards > (I've cc'd them) Isn't that implicitly the case for non-versioned machine types?... Paolo