* [PATCH] tests/unit/test-util-sockets: Remove temporary file after test
@ 2024-02-26 8:27 Thomas Huth
2024-02-26 8:35 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2024-02-26 8:27 UTC (permalink / raw)
To: qemu-devel
Cc: Markus Armbruster, Philippe Mathieu-Daudé,
Marc-André Lureau, qemu-trivial
test-util-sockets leaves the temporary socket files around in the
temporary files folder. Let's better remove them at the end of the
testing.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-util-sockets.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
index 63909ccb2b..4c9dd0b271 100644
--- a/tests/unit/test-util-sockets.c
+++ b/tests/unit/test-util-sockets.c
@@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
test_socket_unix_abstract_row(&matrix[i]);
}
+ unlink(addr.u.q_unix.path);
g_free(addr.u.q_unix.path);
}
--
2.43.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/unit/test-util-sockets: Remove temporary file after test
2024-02-26 8:27 [PATCH] tests/unit/test-util-sockets: Remove temporary file after test Thomas Huth
@ 2024-02-26 8:35 ` Marc-André Lureau
2024-02-26 8:48 ` Philippe Mathieu-Daudé
2024-02-26 9:09 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2024-02-26 8:35 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Markus Armbruster, Philippe Mathieu-Daudé,
qemu-trivial
On Mon, Feb 26, 2024 at 12:28 PM Thomas Huth <thuth@redhat.com> wrote:
>
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/unit/test-util-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
> test_socket_unix_abstract_row(&matrix[i]);
> }
>
> + unlink(addr.u.q_unix.path);
> g_free(addr.u.q_unix.path);
> }
>
> --
> 2.43.2
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/unit/test-util-sockets: Remove temporary file after test
2024-02-26 8:27 [PATCH] tests/unit/test-util-sockets: Remove temporary file after test Thomas Huth
2024-02-26 8:35 ` Marc-André Lureau
@ 2024-02-26 8:48 ` Philippe Mathieu-Daudé
2024-02-26 9:09 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-26 8:48 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Markus Armbruster, Marc-André Lureau, qemu-trivial
On 26/2/24 09:27, Thomas Huth wrote:
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/unit/test-util-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
> test_socket_unix_abstract_row(&matrix[i]);
> }
>
> + unlink(addr.u.q_unix.path);
> g_free(addr.u.q_unix.path);
> }
>
Maybe:
Fixes: 4d3a329af5 ("tests/util-sockets: add abstract unix socket cases")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/unit/test-util-sockets: Remove temporary file after test
2024-02-26 8:27 [PATCH] tests/unit/test-util-sockets: Remove temporary file after test Thomas Huth
2024-02-26 8:35 ` Marc-André Lureau
2024-02-26 8:48 ` Philippe Mathieu-Daudé
@ 2024-02-26 9:09 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2024-02-26 9:09 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Markus Armbruster, Philippe Mathieu-Daudé,
Marc-André Lureau, qemu-trivial
26.02.2024 11:27, Thomas Huth wrote:
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/unit/test-util-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
> test_socket_unix_abstract_row(&matrix[i]);
> }
>
> + unlink(addr.u.q_unix.path);
> g_free(addr.u.q_unix.path);
> }
Added the Fixes: tag as suggested by Philippe, and queued to trivial-patches
tree. Thank you Thomas for this thankless work!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-26 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26 8:27 [PATCH] tests/unit/test-util-sockets: Remove temporary file after test Thomas Huth
2024-02-26 8:35 ` Marc-André Lureau
2024-02-26 8:48 ` Philippe Mathieu-Daudé
2024-02-26 9:09 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).