From: Richard Henderson <richard.henderson@linaro.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: nd@arm.com, qemu-devel@nongnu.org
Subject: Re: tst-arm-mte bug: PSTATE.TCO is cleared on exceptions
Date: Fri, 24 Apr 2020 12:47:46 -0700 [thread overview]
Message-ID: <ec85fd40-229b-c965-1f58-d4cbe825419c@linaro.org> (raw)
In-Reply-To: <a36c670a-5cef-f8c6-ce1d-4fbb28f9488d@linaro.org>
On 4/21/20 9:39 PM, Richard Henderson wrote:
> On 4/20/20 3:29 AM, Szabolcs Nagy wrote:
>> i'm using the branch at
>>
>> https://github.com/rth7680/qemu/tree/tgt-arm-mte
>>
>> to test armv8.5-a mte and hope this is ok to report bugs here.
>>
>> i'm doing tests in qemu-system-aarch64 with linux userspace
>> code and it seems TCO bit gets cleared after syscalls or other
>> kernel entry, but PSTATE is expected to be restored, so i
>> suspect it is a qemu bug.
>>
>> i think the architecture saves/restores PSTATE using SPSR_ELx
>> on exceptions.
>
> Yep. I failed to update aarch64_pstate_valid_mask for TCO.
> Will fix. Thanks,
Fixed on the branch.
I still need to work out how best to plumb the arm,armv8.5-memtag property so
the devel/mte-v3 kernel branch isn't usable as-is for the moment. For myself,
I've just commented that test out for now.
r~
next prev parent reply other threads:[~2020-04-24 19:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 10:29 tst-arm-mte bug: PSTATE.TCO is cleared on exceptions Szabolcs Nagy
2020-04-22 4:39 ` Richard Henderson
2020-04-24 19:47 ` Richard Henderson [this message]
2020-05-06 12:57 ` Szabolcs Nagy
2020-05-07 9:59 ` Szabolcs Nagy
2020-05-07 17:21 ` Richard Henderson
2020-05-18 12:59 ` Szabolcs Nagy
2020-05-19 18:46 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec85fd40-229b-c965-1f58-d4cbe825419c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=nd@arm.com \
--cc=qemu-devel@nongnu.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).