From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC494C433DF for ; Mon, 12 Oct 2020 11:46:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B4862080D for ; Mon, 12 Oct 2020 11:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MSw0Ak/R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B4862080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRwHt-0001v9-Ah for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 07:46:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRwFn-0000Ow-Hm for qemu-devel@nongnu.org; Mon, 12 Oct 2020 07:44:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRwFl-00089W-7B for qemu-devel@nongnu.org; Mon, 12 Oct 2020 07:44:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602503072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8Tykc6KsUxdLq8UdeSSUOuM12RlEJWbwGvm4L5gU1k=; b=MSw0Ak/RxxVvE5OM2XUvL5hULAfSEK6KkceKBltOLAkRwJ/4+6IR1+MNx6XkxIiYpw2xgM NTSSdbYR/ZEng/mfzw/I4vlld1fwn3Xh3OhfNwf/cfBb2wqOEm76cm5SF3GU3y74nCaabR cS81+rvYcVJ8iKqPYI2sDjSzGfLebFY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-N-fpAbTTMD2WeX_iMHI-Pw-1; Mon, 12 Oct 2020 07:44:30 -0400 X-MC-Unique: N-fpAbTTMD2WeX_iMHI-Pw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70C371084C80; Mon, 12 Oct 2020 11:44:29 +0000 (UTC) Received: from [10.3.112.62] (ovpn-112-62.phx2.redhat.com [10.3.112.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BAB755760; Mon, 12 Oct 2020 11:44:28 +0000 (UTC) Subject: Re: [PATCH v4 2/7] test-keyval: Demonstrate misparse of ',' with implied key To: Markus Armbruster , qemu-devel@nongnu.org References: <20201011073505.1185335-1-armbru@redhat.com> <20201011073505.1185335-3-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Mon, 12 Oct 2020 06:44:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201011073505.1185335-3-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/11 23:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/11/20 2:35 AM, Markus Armbruster wrote: > Add a test for "val,,ue" with implied key. Documentation says this > should parse as implied key with value "val", then fail. The code > parses it as implied key with value "val,ue", then succeeds. The next > commit will fix it. > > Signed-off-by: Markus Armbruster > --- > tests/test-keyval.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Eric Blake > > diff --git a/tests/test-keyval.c b/tests/test-keyval.c > index e331a84149..f02bdf7029 100644 > --- a/tests/test-keyval.c > +++ b/tests/test-keyval.c > @@ -182,6 +182,13 @@ static void test_keyval_parse(void) > error_free_or_abort(&err); > g_assert(!qdict); > > + /* Implied key's value can't have comma (qemu_opts_parse(): it can) */ > + /* BUG: it can */ > + qdict = keyval_parse("val,,ue", "implied", &error_abort); > + g_assert_cmpuint(qdict_size(qdict), ==, 1); > + g_assert_cmpstr(qdict_get_try_str(qdict, "implied"), ==, "val,ue"); > + qobject_unref(qdict); > + > /* Empty key is not an implied key */ > qdict = keyval_parse("=val", "implied", &err); > error_free_or_abort(&err); > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org