From: Eric Blake <eblake@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: "Geoffrey McRae" <geoff@hostfission.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset
Date: Fri, 8 Dec 2017 10:24:47 -0600 [thread overview]
Message-ID: <eca9af63-7c72-b3a6-d5b1-883d6e33eecd@redhat.com> (raw)
In-Reply-To: <CABdb737EUy_rRCunxeDUDdhhDiCU8eZBNoYmh+QGp39mqsDung@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On 12/08/2017 07:44 AM, Ladi Prosek wrote:
>>> static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
>>> uint32_t val, int len)
>>> {
>>
>> Why are you moving ivshmem_reset()? Makes the actual change harder to
>> see than necessary.
>
> ivshmem_disable_irqfd() is declared after ivshmem_reset() in the
> source file. I generally prefer to order static functions
> topologically if possible. If you'd prefer adding a forward decl
> instead (fewer lines touched, easier to bisect?) I can certainly do
> that. Thanks!
That, or split it into two patches (one doing just the code motion, the
other making the semantic change).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-12-08 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 7:45 [Qemu-devel] [PATCH v3 0/4] ivshmem: MSI bug fixes Ladi Prosek
2017-12-08 7:45 ` [Qemu-devel] [PATCH v3 1/4] ivshmem: Don't update non-existent MSI routes Ladi Prosek
2017-12-08 7:45 ` [Qemu-devel] [PATCH v3 2/4] ivshmem: Always remove irqfd notifiers Ladi Prosek
2017-12-08 7:45 ` [Qemu-devel] [PATCH v3 3/4] ivshmem: Improve MSI irqfd error handling Ladi Prosek
2017-12-08 7:45 ` [Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset Ladi Prosek
2017-12-08 13:36 ` Markus Armbruster
2017-12-08 13:44 ` Ladi Prosek
2017-12-08 16:24 ` Eric Blake [this message]
2017-12-08 17:28 ` Markus Armbruster
2017-12-08 17:34 ` Ladi Prosek
2017-12-09 7:09 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eca9af63-7c72-b3a6-d5b1-883d6e33eecd@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=geoff@hostfission.com \
--cc=lprosek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).