From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] net: Drop unusual use of do { } while (0);
Date: Thu, 30 Nov 2017 17:08:51 +0100 [thread overview]
Message-ID: <ecbf4f53-8094-658d-75b7-a7cda8a1ca08@redhat.com> (raw)
In-Reply-To: <20171130134159.9697-2-eblake@redhat.com>
On 30.11.2017 14:41, Eric Blake wrote:
> For a couple of macros in pcnet.c, we have to provide a new scope
> to avoid compiler warnings about declarations in the middle of a
> switch statement that aren't in a sub-scope. But use of
> 'do { ... } while (0);' merely to provide that new scope is arcane
> overkill, compared to just using '{ ... }'.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> hw/net/pcnet.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-11-30 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:41 [Qemu-devel] [PATCH 0/3] macro do/while (0) cleanup Eric Blake
2017-11-30 13:41 ` [Qemu-devel] [PATCH 1/3] net: Drop unusual use of do { } while (0); Eric Blake
2017-11-30 16:08 ` Thomas Huth [this message]
2017-11-30 13:41 ` [Qemu-devel] [PATCH 2/3] mips: Tweak location of ';' in macros Eric Blake
2017-11-30 15:33 ` Philippe Mathieu-Daudé
2017-11-30 13:41 ` [Qemu-devel] [PATCH 3/3] maint: Fix macros with broken 'do/while(0); ' usage Eric Blake
2017-11-30 13:54 ` Cornelia Huck
2017-11-30 14:43 ` Michael S. Tsirkin
2017-11-30 14:55 ` Eric Blake
2017-11-30 14:56 ` Dr. David Alan Gilbert
2017-12-04 0:45 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2017-11-30 14:01 ` [Qemu-devel] [PATCH 4/3] checkpatch: Enforce proper do/while (0) style Eric Blake
2017-11-30 17:00 ` Eric Blake
2017-12-01 7:31 ` Markus Armbruster
2017-12-01 14:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecbf4f53-8094-658d-75b7-a7cda8a1ca08@redhat.com \
--to=thuth@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).