Re: [Qemu-devel] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit()

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

On 21.06.2016 11:21, Kevin Wolf wrote:
> Just like block jobs, the HMP commit command should use its own
> BlockBackend for doing I/O on BlockDriverStates.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/commit.c | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/block/commit.c b/block/commit.c
> index 4ac3df3..17f365f 100644
> --- a/block/commit.c
> +++ b/block/commit.c

[...]

> @@ -342,7 +349,7 @@ int bdrv_commit(BlockDriverState *bs)
>  
>      /* qemu_try_blockalign() for bs will choose an alignment that works for
>       * bs->backing->bs as well, so no need to compare the alignment manually. */

This comment will need a little change, too.

With that done: Reviewed-by: Max Reitz <mreitz@redhat.com>

> -    buf = qemu_try_blockalign(bs, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
> +    buf = blk_try_blockalign(src, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
>      if (buf == NULL) {
>          ret = -ENOMEM;
>          goto ro_cleanup;


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]