From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E129C00140 for ; Wed, 24 Aug 2022 04:59:07 +0000 (UTC) Received: from localhost ([::1]:34504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQiTp-0000XK-Qz for qemu-devel@archiver.kernel.org; Wed, 24 Aug 2022 00:59:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQiSK-0007yt-93 for qemu-devel@nongnu.org; Wed, 24 Aug 2022 00:57:32 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:37152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQiSC-00081N-7f for qemu-devel@nongnu.org; Wed, 24 Aug 2022 00:57:27 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R171e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045192; MF=kangjie.xu@linux.alibaba.com; NM=1; PH=DS; RN=9; SR=0; TI=SMTPD_---0VN5ppuf_1661317034; Received: from 30.227.72.120(mailfrom:kangjie.xu@linux.alibaba.com fp:SMTPD_---0VN5ppuf_1661317034) by smtp.aliyun-inc.com; Wed, 24 Aug 2022 12:57:15 +0800 Message-ID: Date: Wed, 24 Aug 2022 12:57:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 18/24] vhost-net: vhost-user: update vhost_net_virtqueue_stop() To: Jason Wang References: <303811ffeac48647ac4c81eeec542292e8f67a0e.1660611460.git.kangjie.xu@linux.alibaba.com> <3b60bcab-f69b-7ec9-caa8-c5947a14b659@redhat.com> From: Kangjie Xu Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, f4bug@amsat.org, wangyanan55@huawei.com, hengqi@linux.alibaba.com, Xuan Zhuo In-Reply-To: <3b60bcab-f69b-7ec9-caa8-c5947a14b659@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.44; envelope-from=kangjie.xu@linux.alibaba.com; helo=out30-44.freemail.mail.aliyun.com X-Spam_score_int: -98 X-Spam_score: -9.9 X-Spam_bar: --------- X-Spam_report: (-9.9 / 5.0 requ) BAYES_00=-1.9, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/8/24 12:05, Jason Wang 写道: > > 在 2022/8/16 09:06, Kangjie Xu 写道: >> Update vhost_net_virtqueue_stop() for vhost-user scenario. > > > Let's explain why it is needed now or why it doesn't cause any issue > or it's a bug fix or not. > > Thanks > This patch is to suppport vq reset for vhost-user. We need this simply because the behavior of vhost_ops->get_vq_index() is different in vhost-user and vhost-kernel. vhost_user_get_vq_index(dev, idx) simply returns "idx". vhost_kernel_get_vq_index(dev, idx) returns "idx - dev->vq_index". Thanks > >> >> Signed-off-by: Kangjie Xu >> Signed-off-by: Xuan Zhuo >> --- >>   hw/net/vhost_net.c | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c >> index 2ab67e875e..c0d408f3b4 100644 >> --- a/hw/net/vhost_net.c >> +++ b/hw/net/vhost_net.c >> @@ -533,6 +533,10 @@ void vhost_net_virtqueue_stop(VirtIODevice >> *vdev, NetClientState *nc, >>           assert(r >= 0); >>       } >>   +    if (net->nc->info->type == NET_CLIENT_DRIVER_VHOST_USER) { >> +        idx = idx - net->dev.vq_index; >> +    } >> + >>       vhost_dev_virtqueue_stop(&net->dev, vdev, idx); >>   }