From: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
qemu block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Zhang Yi <yi.z.zhang@linux.intel.com>,
Junyan He <junyan.he@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec
Date: Fri, 21 Feb 2020 13:20:30 -0700 [thread overview]
Message-ID: <ecee88f1-0fcf-a421-bdde-6506db508e96@linux.intel.com> (raw)
In-Reply-To: <CAJSP0QUFJoBANYO0=42vfcPS8MUZJdKab=g88cpVW6oD_UoV5A@mail.gmail.com>
On 2/21/20 12:32 PM, Stefan Hajnoczi wrote:
> Hi Andrzej,
> After having looked at the PMRWBM part of the spec, I think that the
> Bit 1 mode should be implemented for slightly better performance. Bit
> 0 mode is not well-suited to virtualization for the reasons I
> mentioned in the previous email.
>
> The spec describes Bit 1 mode as "The completion of a read to the
> PMRSTS register shall ensure that all prior writes to the Persistent
> Memory Region have completed and are persistent".
>
> Stefan
Make sense -- will incorporate that feedback in second version of patch.
next prev parent reply other threads:[~2020-02-21 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:48 [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec Andrzej Jakowski
2020-02-19 1:07 ` no-reply
2020-02-19 20:25 ` Andrzej Jakowski
2020-02-21 13:45 ` Stefan Hajnoczi
2020-02-21 15:36 ` Andrzej Jakowski
2020-02-21 17:31 ` Stefan Hajnoczi
2020-02-21 17:50 ` Dr. David Alan Gilbert
2020-02-21 18:29 ` Stefan Hajnoczi
2020-02-21 19:32 ` Stefan Hajnoczi
2020-02-21 20:20 ` Andrzej Jakowski [this message]
2020-02-21 18:45 ` Dr. David Alan Gilbert
2020-02-21 20:19 ` Andrzej Jakowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecee88f1-0fcf-a421-bdde-6506db508e96@linux.intel.com \
--to=andrzej.jakowski@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=junyan.he@intel.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=yi.z.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).