From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation with clang 3.4
Date: Wed, 28 Nov 2018 15:39:28 +0100 [thread overview]
Message-ID: <ed0252f7-e74c-46e1-b47b-8d0c2e8dd73e@redhat.com> (raw)
In-Reply-To: <2ac07515-10f3-ed38-c022-e583cd1cd36a@redhat.com>
On 2018-11-28 15:34, Philippe Mathieu-Daudé wrote:
> On 28/11/18 10:58, Thomas Huth wrote:
>> Clang 3.4 does not know the "flatten" attribute yet. We've already
>> introduced the QEMU_FLATTEN macro for this in commit 97ff87c0ed020c2,
>> so use this macro now here, too, to fix this issue.
>
> checkpatch candidate?
I think we'd rather need a docker-based test with such an old version of
Clang... (since there are also other issues like the double-typedef
problem that regularly occurs there).
Thomas
next prev parent reply other threads:[~2018-11-28 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:58 [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation with clang 3.4 Thomas Huth
2018-11-28 14:09 ` Richard Henderson
2018-11-28 14:34 ` Philippe Mathieu-Daudé
2018-11-28 14:39 ` Thomas Huth [this message]
2018-11-28 15:50 ` Philippe Mathieu-Daudé
2018-11-28 15:54 ` Peter Maydell
2018-11-28 15:32 ` Peter Maydell
2018-11-28 16:05 ` Daniel P. Berrangé
2018-11-28 16:50 ` Thomas Huth
2018-11-28 16:58 ` Daniel P. Berrangé
2018-11-28 19:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0252f7-e74c-46e1-b47b-8d0c2e8dd73e@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).