From: Thomas Huth <thuth@redhat.com>
To: Gan Qixin <ganqixin@huawei.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: zhang.zhanghailiang@huawei.com, mst@redhat.com,
laurent@vivier.eu, armbru@redhat.com, kuhn.chenqun@huawei.com,
philmd@redhat.com
Subject: Re: [PATCH v3 4/4] max111x: put it into the 'misc' category
Date: Fri, 13 Nov 2020 08:14:47 +0100 [thread overview]
Message-ID: <ed0e1207-b37d-7e6f-0bf1-4e473ac00df6@redhat.com> (raw)
In-Reply-To: <20201112125824.763182-5-ganqixin@huawei.com>
On 12/11/2020 13.58, Gan Qixin wrote:
> The category of the max111x device is not set, put it into the 'misc'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> hw/misc/max111x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c
> index 7e6723f343..eae0f9b598 100644
> --- a/hw/misc/max111x.c
> +++ b/hw/misc/max111x.c
> @@ -185,6 +185,7 @@ static void max111x_class_init(ObjectClass *klass, void *data)
> k->transfer = max111x_transfer;
> dc->reset = max111x_reset;
> dc->vmsd = &vmstate_max111x;
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> }
>
> static const TypeInfo max111x_info = {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-11-13 7:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
2020-11-13 10:12 ` Peter Maydell
2020-11-13 11:14 ` ganqixin
2020-11-16 12:46 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
2020-11-13 7:14 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0e1207-b37d-7e6f-0bf1-4e473ac00df6@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).