From: "Lukáš Doktor" <ldoktor@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Performance improvement with 6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee
Date: Thu, 25 May 2023 12:18:09 +0200 [thread overview]
Message-ID: <ed0f3a6a-75f3-c6d5-8eb9-3f1575fc0766@redhat.com> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 1909 bytes --]
Hello Stefan, folks,
the perf-ci detected and bisected the 6d740fb - aio-posix: do not nest poll handlers - as a performance improvement when using multiple concurrent jobs and 4k (22%) as well as 1024k (63%) blocks on aarch64 (on a slow rotational disk).
https://ldoktor.github.io/tmp/RedHat-virtlab-arm09/v8.0.0/150-improvement.html
Based on the commit message I guess it's expected so take this just as a record of an improvement.
Bisect log:
git bisect start
# good: [aa222a8e4f975284b3f8f131653a4114b3d333b3] Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging
git bisect good aa222a8e4f975284b3f8f131653a4114b3d333b3
# bad: [ad3387396a71416cacc0b394e5e440dd6e9ba19a] Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging
git bisect bad ad3387396a71416cacc0b394e5e440dd6e9ba19a
# good: [71438d8dac07f28c01cf6d90fce14efe04c77824] graph-lock: Honour read locks even in the main thread
git bisect good 71438d8dac07f28c01cf6d90fce14efe04c77824
# good: [4b424c757188f7a47630a4d8edcf4ad9f19255bc] scripts: make sure scripts are invoked via $(PYTHON)
git bisect good 4b424c757188f7a47630a4d8edcf4ad9f19255bc
# bad: [80fc5d260002432628710f8b0c7cfc7d9b97bb9d] graph-lock: Disable locking for now
git bisect bad 80fc5d260002432628710f8b0c7cfc7d9b97bb9d
# bad: [6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee] aio-posix: do not nest poll handlers
git bisect bad 6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee
# good: [78935fcd88ec2d26d50e45043b262f0326e6d410] iotests/245: Check if 'compress' driver is available
git bisect good 78935fcd88ec2d26d50e45043b262f0326e6d410
# first bad commit: [6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee] aio-posix: do not nest poll handlers
Regards,
Lukáš
PS: The list of perf-ci issues is available here: https://docs.google.com/spreadsheets/d/1HEXI5wDsNgAIgXl5MIhGond898Vz5A1Hrkl0lZmWEbg/edit#gid=0
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 12925 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next reply other threads:[~2023-05-25 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 10:18 Lukáš Doktor [this message]
2023-05-25 15:21 ` Performance improvement with 6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee Stefan Hajnoczi
2023-05-26 8:06 ` Lukáš Doktor
2023-05-26 10:56 ` Stefan Hajnoczi
2023-05-31 16:50 ` Lukáš Doktor
2023-05-31 17:14 ` Stefan Hajnoczi
2023-06-01 4:23 ` Performance improvement and regression " Lukáš Doktor
2023-06-01 13:17 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0f3a6a-75f3-c6d5-8eb9-3f1575fc0766@redhat.com \
--to=ldoktor@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).